TSAN unaligned store lowering is wrong
Currently the -fcmm-thread-sanitizer
logic for handling unaligned stores is incorrect. Specifically, it currently calls __tsan_unaligned_write
but passes it only the address to be written, not the value. This is wrong as it according to some references, unaligned_write
should take both as arguments. However, strangely other sources claim otherwise.
Regardless, for now I'm going to disable instrumentation of unaligned writes.