Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • GHC GHC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 5.5k
    • Issues 5.5k
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 636
    • Merge requests 636
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Glasgow Haskell CompilerGlasgow Haskell Compiler
  • GHCGHC
  • Merge requests
  • !10500

JS: Convert rendering to use HLine instead of SDoc

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Josh Meredith requested to merge wip/js-hline into master May 22, 2023
  • Overview 12
  • Commits 1
  • Pipelines 8
  • Changes 11

#22455

This MR changes the JavaScript code rendering of rts.js and out.js to use the newer HLine system.

Additionally, a flag (-ddisable-js-minifier) is added which sets the code rendering back to use SDocs:

  • The SDoc rendering is improved from previously, which used layLeft for code size. Now, because we only use SDocs for debug rendering, the code is readably intended
  • The HLine and SDoc rendering only differs by whitespace - controlled by the JsRender class.
Edited May 24, 2023 by Josh Meredith
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/js-hline