Skip to content

cg: Remove GHC.Cmm.DataFlow.Collections

jeffrey young requested to merge doyougnu/ghc:wip/doyougnu/cg/use-uniqfm into master

Removing DataFlow.Collections and using Word64Map/Set instead. This achieves a few things:

  • removes a lingering todo in the compiler
  • removes a bunch of unnecessary polymorphism
  • removes a module. The Collections module came from removing the Hoopl dependency and has stayed with us since then.

Todos:

  • CI passes
  • make projections: LabelSet -> Word64Map/Set and see if I can remove some lingering imports of Dataflow.Label. There were a handful of modules that only import Label to deconstruct a LabelMap. Edit: its not worth coupling into a sister component such as Dataflow.Graph.
  • run a single full CI before marking as ready; I don't want to mess up Wasm.
Edited by jeffrey young

Merge request reports