base: Propagate `error` CallStack to thrown exception

Previously errorCallWithCallStackException failed to propagate its CallStack argument, which represents the call-chain of the preceding error call, to the exception that it returned. Consequently, the call-stack of error calls were quite useless.

Unfortunately, this is the second time that I have fixed this but it seems the first must have been lost in rebasing. The added test should prevent any further shenanigans.

Fixes #24807 (closed).

approved this merge request

added backport needed:9.10 label

added 4404 commits

• a7237b11...3939a8bf - 4403 commits from branch master
• 7e56649e - base: Propagate `error` CallStack to thrown exception

Compare with previous version

added backport needed:9.12 label

added 1 commit

• 5963b8c2 - base: Propagate `error` CallStack to thrown exception

Compare with previous version

assigned to @marge-bot

I will attempt to batch this MR (!13278 (closed))...

Batch MR !13278 (closed) failed: CI failed! I will retry later...

I will attempt to batch this MR (!13281 (closed))...

Batch MR !13281 (closed) failed: CI failed! I will retry later...

errorCallWithCallStackException is exported from base. Why changing its behaviour does not need a CLC proposal?

I will attempt to batch this MR (!13282 (closed))...

unassigned @marge-bot

assigned to @alt-romes

Batch MR !13282 (closed) failed: Someone canceled the CI. I will retry later...

added 19 commits

• 5963b8c2...c0df5aa9 - 18 commits from branch master
• 72a85e43 - base: Propagate `error` CallStack to thrown exception

Compare with previous version

assigned to @marge-bot and unassigned @alt-romes

resolved all threads

mentioned in issue #25283 (closed)

@alt-romes could you please update libraries/base/changelog.md as it's the case for other changes to base?

assigned to @alt-romes and unassigned @marge-bot

added 1 commit

• 5e81a005 - base: Propagate `error` CallStack to thrown exception

Compare with previous version

assigned to @marge-bot and unassigned @alt-romes

resolved all threads

changed milestone to %9.12.1

I will attempt to batch this MR (!13309 (closed))...

Merged in 5f7c20bc

closed

removed backport needed:9.12 label

mentioned in issue #25433

mentioned in merge request !13861 (merged)

%9.10.2 backport in !13861 (merged)

removed backport needed:9.10 label