Skip to content

Remove duplicate Anno instances

Jan Hrček requested to merge jhrcek/ghc:jhrcek/remove-duplicate-Anno-instances into master

When reading this haddock it caught my eye that there are 2 identical type family instances for type Anno (Maybe Role).

Turns out there are more duplicated instances as shown below:

$ cd compiler
% grep 'type instance Anno' -rh | sort | uniq -c | sort
# ... omitting unique instances
      2 type instance Anno (FamEqn (GhcPass p) _) = SrcSpanAnnA
      2 type instance Anno [LocatedA (StmtLR (GhcPass pl) (GhcPass pr) (LocatedA (HsCmd (GhcPass pr))))]
      2 type instance Anno (Maybe Role) = EpAnnCO
      2 type instance Anno ModuleName = SrcSpanAnnA
      2 type instance Anno OverlapMode = SrcSpanAnnP

I also checked all type instance occurrences (not just of Anno) and didn't find further duplicates.

Edited by Jan Hrček

Merge request reports