Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • GHC GHC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 5,242
    • Issues 5,242
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 564
    • Merge requests 564
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Glasgow Haskell CompilerGlasgow Haskell Compiler
  • GHCGHC
  • Merge requests
  • !1324

Make printer untag when chasing a pointer in a RET_FUN frame

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Siddharth requested to merge bollu/ghc:july-1-make-printer-untag-pointer-RET_FUN into master Jul 01, 2019
  • Overview 3
  • Commits 1
  • Pipelines 2
  • Changes 1

This matches what Scav.c does: https://github.com/ghc/ghc/blob/2ff77b9894eecf51fa619ed2266ca196e296cd1e/rts/sm/Scav.c#L1950

@mpickering asked me to think of a nice way to test this. Unfortunately, I'm blanking on this aspect.

I wondered if it's possible to have some sort of visitor-like infrastructure, so that delicate bugs like these can be fixed once-per-visitor, rather than n times for the number of things that walk the heap. Unfortunately, @bgamari mentioned that this might introduce hard-to-predict performance regressions due to our inability to control the generated code.

Would having a separate Visitor-like infrastructure make testing this easier?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: july-1-make-printer-untag-pointer-RET_FUN