Skip to content
Snippets Groups Projects

Don't report used duplicate record fields as unused

Closed sheaf requested to merge sheaf/ghc:T24035 into master

Ticket: #24035 (closed)

This MR fixes the bug reported in #24035 (closed) in which the import of a duplicate record field could be erroneously reported as unused.

The issue is that an import of the form import M (fld) can import several different Names, and we should only report an error if ALL of those Names are unused, not if ANY are.

Note [Reporting unused imported duplicate record fields] in GHC.Rename.Names explains the solution to this problem.

Merge request reports

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rodrigo Mesquita requested review from @alt-romes

    requested review from @alt-romes

  • Rodrigo Mesquita approved this merge request

    approved this merge request

  • Very good. Feel free to land it.

  • sheaf resolved all threads

    resolved all threads

  • assigned to @marge-bot

  • sheaf added 1 commit

    added 1 commit

    • c6af899e - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • sheaf added 34 commits

    added 34 commits

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading