Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • GHC GHC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 5,248
    • Issues 5,248
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 561
    • Merge requests 561
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Glasgow Haskell CompilerGlasgow Haskell Compiler
  • GHCGHC
  • Merge requests
  • !146

Fix two bugs in stg_ap_0_fast in profiling runtime

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ömer Sinan Ağacan requested to merge osa1/ghc:fix_ap_0_ret_prof into master Jan 18, 2019
  • Overview 20
  • Commits 1
  • Pipelines 6
  • Changes 1

This includes two bug fixes in profiling version of stg_ap_0_fast:

  • PAPs allocated by stg_ap_0_fast are now correctly tagged. This invariant is checked in Sanity.c:checkPAP.

    (This was originally implemented in 2693eb11, later reverted with ab55b4dd because it revealed the bug below, but it wasn't clear at the time whether the bug was the one below or something in the commit)

  • The local variable untaggedfun is now marked as a pointer so it survives GC.

With this we finally fix all known bugs caught in #15508 (closed). concprog001 now works reliably with prof+threaded and prof runtimes (with and without -debug).

Edited Jan 19, 2019 by Ömer Sinan Ağacan
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_ap_0_ret_prof