Improve tests for #17171
While backporting MR !1806 (closed) to 8.8.2 (!1885 (closed)) I learnt the following:
- Tests with
expect_fail
do not compare*.stderr
output files. So a test usingexpect_fail
will not detect future regressions on thestderr
output. - To compare the
*.stderr
output files, I have to use theexit_code(n)
function. - When a release is made, tests with
makefile_test
are converted to userun_command
. - For the test
T17171a
the return code is1
when runningmakefile_test
, however it's2
when runningrun_command
.
Therefore I decided:
- To improve my tests for #17171 (closed)
- To change test T17171a from
expect_fail
toexit_code(2)
- To change both tests from
makefile_test
torun_command