Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • GHC GHC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 5.5k
    • Issues 5.5k
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 628
    • Merge requests 628
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Glasgow Haskell CompilerGlasgow Haskell Compiler
  • GHCGHC
  • Merge requests
  • !2377

Accumulate Haddock comments in P (#17544, #17561, #8944)

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Vladislav Zavialov requested to merge wip/haddock-accum into master Dec 27, 2019
  • Overview 229
  • Commits 1
  • Pipelines 25
  • Changes 41

This patch implements the idea outlined in #17544 (closed):

  • Accumulate Haddock comments with their locations in the P monad. This is handled in the lexer.

  • After parsing, do a pass over the AST to associate Haddock comments with AST nodes using location info.

  • Report the leftover comments to the user as a warning (-Winvalid-haddock).

As the result, it fixes #17561 (closed) and #8944 (closed).

Edited Jul 01, 2020 by Vladislav Zavialov
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/haddock-accum