Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
GHC
GHC
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 4,310
    • Issues 4,310
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 382
    • Merge Requests 382
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Glasgow Haskell Compiler
  • GHCGHC
  • Merge Requests
  • !3342

Closed
Opened May 24, 2020 by Roland Senn@RolandSennDeveloper
  • Report abuse
Report abuse

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch "https://gitlab.haskell.org/RolandSenn/ghc.git" "T11596"
git checkout -b "RolandSenn/ghc-T11596" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "master"
git merge --no-ff "RolandSenn/ghc-T11596"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

WIP: In GHCi don't defer the error message `Could not find module`. (Fixes #11596)

  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 7

When should GHC report the error message Could not find module? There are 2 options:

  1. at the time GHC tries to read the file with the module code.
  2. at the time GHC tries to compile code from the missing input file.

The patch ff3f918d for #11256 (closed) changed from option 1. to option 2. As a side effect we got #11596: A GHCi :reload command gets confused if an input file has been deleted: GHCi doesn't report the error on a :reload command, however the evaluation of the next expression fails with a very obscure error message!

Therefore this patch uses again option 1. for GHCi, and continues to use option 2. for GHC.

Assignee
Assign to
9.0.1
Milestone
9.0.1 (Past due)
Assign milestone
Time tracking
Reference: ghc/ghc!3342
Source branch: T11596