Skip to content

Inline pragmas for pattern synonyms

cgibbard requested to merge obsidiansystems/ghc:inline-pat-syn into master

Related issue: #12178 (closed)

This is a rebase and slight cleanup of !1047 (closed) (I didn't have permissions to commit to the original repo, so I pushed it to Obsidian's instead).

Following the rebase, I've fixed up the shift/reduce conflict in the parser (well, annotated it with %shift and added a Note), and then fixed up the tests to be hopefully slightly more reliable. We're still grepping through Core output, but hopefully in a way which isn't quite as fragile.

Thank you for your contribution to GHC!

Please take a few moments to verify that your commits fulfill the following:

  • are either individually buildable or squashed
  • have commit messages which describe what they do (referring to Notes and tickets using #NNNN syntax when appropriate)
  • have added source comments describing your change. For larger changes you likely should add a Note and cross-reference it from the relevant places.
  • add a testcase to the testsuite.
  • replace this message with a description motivating your change

If you have any questions don't hesitate to open your merge request and inquire in a comment. If your patch isn't quite done yet please do add prefix your MR title with WIP:.

Edited by Madeline Haraj

Merge request reports