Skip to content

Add missing fixed-sized primops and constant folding

John Ericson requested to merge wip/fixed-sized-constant-fold into master

Part of the work towards #19026 (closed).

  • inversePrimOp is renamed to semiInversePrimOp to indicate the given primop is only a right inverse, not left inverse (and contra-wise for the primop which we are giving rules for). This explains why are new usage is not incorrect.

  • The removed subsumedByPrimOp calls were actually dead as the match on ill-typed code. @hsyl20 pointed this out in !4390 (closed) (comment 311912),

Please take a few moments to verify that your commits fulfill the following:

  • are either individually buildable or squashed
  • have commit messages which describe what they do (referring to Notes and tickets using #NNNN syntax when appropriate)
  • have added source comments describing your change. For larger changes you likely should add a Note and cross-reference it from the relevant places.
  • add a testcase to the testsuite.
  • replace this message with a description motivating your change

If you have any questions don't hesitate to open your merge request and inquire in a comment. If your patch isn't quite done yet please do add prefix your MR title with WIP:.

Edited by John Ericson

Merge request reports