Skip to content
Snippets Groups Projects

Bignum: fix bogus rewrite rule (#19345)

Closed Bignum: fix bogus rewrite rule (#19345)
hsyl20/ghc:hsyl20/bignum19345 into master
1 unresolved thread
Closed Sylvain Henry requested to merge hsyl20/ghc:hsyl20/bignum19345 into master
1 unresolved thread

Fix the following rule:

  "fromIntegral/Int->Natural" fromIntegral = naturalFromWord . fromIntegral

Its type wasn't constrained to Int hence #19345 (closed).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sylvain Henry added 1 commit

    added 1 commit

    Compare with previous version

  • Sylvain Henry added 1 commit

    added 1 commit

    Compare with previous version

  • Simon Peyton Jones
    Simon Peyton Jones @simonpj started a thread on an old version of the diff
    • libraries/base/GHC/Real.hs
    580 580 #-}
    581 581
    582 582 {-# RULES
    583 "fromIntegral/Natural->Natural" fromIntegral = id :: Natural -> Natural
    584 "fromIntegral/Natural->Integer" fromIntegral = toInteger :: Natural->Integer
    585 "fromIntegral/Natural->Word" fromIntegral = naturalToWord
    583 "fromIntegral/Natural->Natural" fromIntegral = id :: Natural -> Natural
    584 "fromIntegral/Natural->Integer" fromIntegral = toInteger :: Natural -> Integer
    585 "fromIntegral/Natural->Word" fromIntegral = naturalToWord :: Natural -> Word
    586 586 #-}
    587 587
    588 -- Don't forget the types in the following rules! See #19345 for an example of
    589 -- bug introduced because of a missing type in the following rule:
    590 --
    591 -- "fromIntegral/Int->Natural" fromIntegral = naturalFromWord . fromIntegral
  • Sylvain Henry added 1 commit

    added 1 commit

    Compare with previous version

  • Sylvain Henry added 1 commit

    added 1 commit

    Compare with previous version

  • Sylvain Henry assigned to @marge-bot

    assigned to @marge-bot

  • Marge Bot
    Marge Bot @marge-bot ·
    Owner

    I will attempt to batch this MR (!4990 (closed))...

  • Marge Bot
    Marge Bot @marge-bot ·
    Owner

    Batch MR !4990 (closed) failed: CI failed! I will retry later...

  • Marge Bot
    Marge Bot @marge-bot ·
    Owner

    I will attempt to batch this MR (!5003 (closed))...

  • Marge Bot
    Marge Bot @marge-bot ·
    Owner

    Merged in 5e71dd33

  • Marge Bot closed

    closed

  • Sylvain Henry mentioned in merge request !5014 (merged)

    mentioned in merge request !5014 (merged)

  • Krzysztof Gogolewski removed 1 deleted label

    removed 1 deleted label

  • Krzysztof Gogolewski
    Krzysztof Gogolewski @monoidal ·
    Developer

    Backported in !5014 (merged).

  • Krzysztof Gogolewski mentioned in issue #19411 (closed)

    mentioned in issue #19411 (closed)

    • Please register or sign in to reply