Fix Storeable instances for the windows timeout executable.

Compute the alignment from the size, instead of using the size.

We do so by rounding up to the next power of two.

Fixes #19392 (closed).

This limitation should really be better documented. Moreover, given that all Storable instances will need to do this, we should probably have a function like alignmentFromSize im base

If alignment always have to be a power of 2 then the field should be an Int which represents with exponent. This would obviously break every instance.

It seems better to me to just fix the alignment to the nearest power of two when it's necessary if it's not already.

added 25 commits

• ff4721e2...dbf8f6fe - 24 commits from branch master
• 5bd581ba - Fix Storeable instances for the windows timeout executable.

Compare with previous version

Echoing my comments from https://github.com/haskell/win32/issues/172#issuecomment-780573861, why not just use #alignment here instead? That seems like a much more direct solution.

added 1 commit

• ae103251 - Fix Storeable instances for the windows timeout executable.

Compare with previous version

added 1 commit

• 2d7b7ca2 - Fix Storeable instances for the windows timeout executable.

Compare with previous version

approved this merge request

LGTM, although the commit message should probably be updated to reflect the new solution used in the patch itself.

added 1 commit

• 65c2ed01 - Fix Storeable instances for the windows timeout executable.

Compare with previous version

mentioned in issue #19392 (closed)

resolved all threads

assigned to @marge-bot

I will attempt to batch this MR (!5083 (closed))...

Batch MR !5083 (closed) failed: CI failed! I will retry later...

I will attempt to batch this MR (!5085 (closed))...

Batch MR !5085 (closed) failed: CI failed! I will retry later...

I will attempt to batch this MR (!5088 (closed))...

Batch MR !5088 (closed) failed: CI failed! I will retry later...

I will attempt to batch this MR (!5096 (merged))...

Batch MR !5096 (merged) failed: CI failed! I will retry later...