#18516 (GHC Errors as Values) Implement "Design A" to suppress unwanted warnings
See #18516.
This MR was opened on top of wip/adinapoli-diag-reason-severity for ease of review. It implements the Design A in the Wiki for suppressing warnings that user shouldn't see due to enabled WarningFlags. This is one of the two proposed designs by @rae that we are evaluating.
In particular, this introduces a new Severity constructor called SevIgnore, which is used to suppress WarningWithFlag diagnostics for which the particular flag is not set. It also allowed us to simplify the GHC.Tc.Errors further, in a quite nice way.
Under both designs, we don't need to check anymore if a particular warning flag is set before generating the relevant diagnostic: rather, we always generate and collect it, but we discard it at the end if it turns out the user is not supposed to see it. This was simple to code but it's potentially very performance taxing (thus the need to explore design B).
I have run only a selection of 125 tests locally (CI will give us proper perf results) but it seems like time performance is roughly the same. More interesting will be, of course, memory allocations.
Merge request reports
Activity
added error messages label
added 49 commits
Toggle commit listmentioned in merge request !5278 (closed)
MR !5278 (closed) implements "Design B". It will be interesting to compare the result of the perf tests from both.
- Resolved by Alfredo Di Napoli
T14052 regresses by almost 4%. Definitely worth looking into.
added 58 commits
-
506821c1...3df429c2 - 50 commits from branch
wip/adinapoli-diag-reason-severity - 525d6e0a - Introduce SevIgnore as a Severity
- 8cf303d3 - WIP-01 Simplify redundant checks
- 3da8dcf9 - WIP-02 remove a bunch of when (wopt ...)
- 343c0244 - WIP-03 simplify GHC.Tc.Errors
- 8df52100 - Minor style adjustments
- f967f5ea - Try to avoid some work
- b5743354 - Avoid even more work
- 83172c76 - Code review
Toggle commit list-
506821c1...3df429c2 - 50 commits from branch
