Skip to content

visually align expected and actual modules name

iori requested to merge matsumonkie/ghc:19735-wip/matsumonkie/make-error-message-more-readable into master

visually align expected and actual modules name when file modules does not match module name:

before:

> /home/matt/Projects/persistent/persistent/Database/Persist/ImplicitIdDef.hs:1:8: error:
>     File name does not match module name:
>     Saw: ‘A.B.Module’
>     Expected: ‘A.B.Motule’
>   |
> 1 | module A.B.Motule
>   |        ^^^^^^^^^^>

after:

> /home/matt/Projects/persistent/persistent/Database/Persist/ImplicitIdDef.hs:1:8: error:
>     File name does not match module name:
>     Saw:      ‘A.B.Module’
>     Expected: ‘A.B.Motule’
>   |
> 1 | module A.B.Motule
>   |        ^^^^^^^^^^>

Please take a few moments to verify that your commits fulfill the following:

  • are either individually buildable or squashed
  • have commit messages which describe what they do (referring to [Notes][notes] and tickets using #NNNN syntax when appropriate)
  • have added source comments describing your change. For larger changes you likely should add a [Note][notes] and cross-reference it from the relevant places.
  • add a testcase to the testsuite.
  • replace this message with a description motivating your change

Closes #19735 (closed)

Merge request reports