Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • GHC GHC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 5,357
    • Issues 5,357
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 566
    • Merge requests 566
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Glasgow Haskell CompilerGlasgow Haskell Compiler
  • GHCGHC
  • Merge requests
  • !6090

th: Weaken return type of myCoreToStgExpr

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Matthew Pickering requested to merge wip/t20060 into master Jun 29, 2021
  • Overview 6
  • Commits 1
  • Pipelines 2
  • Changes 5

The previous code assumed properties of the CoreToStg translation, namely that a core let expression which be translated to a single non-recursive top-level STG binding. This assumption was false, as evidenced by #20060 (closed).

The consequence of this was the need to modify the call sites of myCoreToStgExpr, the main one being in hscCompileCoreExpr', which the meant we had to use byteCodeGen instead of stgExprToBCOs to convert the returned value to bytecode.

I removed the stgExprToBCOs function as it is no longer used in the compiler.

There is still some partiallity with this patch (the lookup in hscCompileCoreExpr') but this should be more robust that before.

Fixes #20060 (closed)

cc @luite

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/t20060