Skip to content
Snippets Groups Projects

Add late cost centre support

Closed Andreas Klebinger requested to merge wip/andreask/late_cc into master
1 unresolved thread

Docs have been added. Everything works as expected see the docs for details.

I will assign to marge when CI passes.

Fixes #16765 (closed).

Edited by Ben Gamari

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Matthew Pickering
  • Needs user guide documentation and test, otherwise this produces very nice profiles.

  • added 1 commit

    • 1f0463a0 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • 055044df - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

    • Resolved by Andreas Klebinger

      If you build the memory package with this patch you get this bug

      [ 7 of 29] Compiling Data.Memory.Internal.CompatPrim ( Data/Memory/Internal/CompatPrim.hs, dist/build/Data/Memory/Internal/CompatPrim.p_o )
      ghc: panic! (the 'impossible' happened)
        (GHC version 9.2.1.20211212:
      	tyConAppTyCon
        a_11
        Call stack:
            CallStack (from HasCallStack):
              callStackDoc, called at compiler/GHC/Utils/Panic.hs:181:37 in ghc:GHC.Utils.Panic
              pprPanic, called at compiler/GHC/Core/Type.hs:1428:52 in ghc:GHC.Core.Type
      
      Please report this as a GHC bug:  https://www.haskell.org/ghc/reportabug
      
      cabal: Failed to build memory-0.16.0 (which is required by exe:graphql-engine
      from graphql-engine-1.0.0). See the build log above for details.
  • added 1 commit

    • 3ed4496b - Don't push ticks into type applications

    Compare with previous version

  • added 3 commits

    • f561ed32 - Add late cost centre support
    • f5986800 - Don't push ticks into type applications
    • 0c60ea0d - clean up imports

    Compare with previous version

  • Andreas Klebinger added 130 commits

    added 130 commits

    Compare with previous version

  • Andreas Klebinger marked this merge request as ready

    marked this merge request as ready

  • Andreas Klebinger added 34 commits

    added 34 commits

    Compare with previous version

  • Redundant imports are causing CI to fail.

  • Left a few comments.

  • Andreas Klebinger added 18 commits

    added 18 commits

    Compare with previous version

  • added 1 commit

    • 7822e423 - Add late cost centre support

    Compare with previous version

  • Andreas Klebinger added 40 commits

    added 40 commits

    Compare with previous version

  • Andreas Klebinger changed the description

    changed the description

  • Andreas Klebinger resolved all threads

    resolved all threads

  • Andreas Klebinger added 16 commits

    added 16 commits

    Compare with previous version

  • Andreas Klebinger added 13 commits

    added 13 commits

    Compare with previous version

  • I will attempt to batch this MR (!7540 (closed))...

  • Batch MR !7540 (closed) failed: CI failed! I will retry later...

  • I will attempt to batch this MR (!7541 (closed))...

  • closed

  • 438 438 or the :rts-flag:`-xc` RTS flag (:ref:`rts-options-debugging`) for more
    439 439 details.
    440 440
    441 .. ghc-flag:: -fprof-late-ccs
    442 :shortdesc: Auto-add ``SCC``\\ s to all top level bindings *after* the optimizer has run.
    443 :type: dynamic
    444 :reverse: -fno-prof-auto
  • Ben Gamari changed the description

    changed the description

  • Please register or sign in to reply
    Loading