Skip to content

Various fixes in preparation for new Windows toolchain

Ben Gamari requested to merge wip/windows-test-fixes into master

This merge request is part of a series enabling ASLR support on Windows. See !7448 (closed) for an overview.

These are preparatory patches from !7384 (closed) fixing various latent testsuite bugs:

  • T17786 needs to explicitly enable caret diagnostics as GHC may conclude that the error isn't going to a tty. I'm not sure why we didn't observe this earlier.
  • Normalise away the cost-center numbers from the output of T7275
  • Refactor closurePtrs# to allocate on the C heap rather than the stack. Not only is this good practice since heap objects can be quite large, but I found it to be necessary since Windows has a much smaller C stack size
  • Refactor T4029 to use printf rather than echo, since the behavior of echo without an argument tends to vary across platforms.
Edited by Ben Gamari

Merge request reports