Skip to content

Don't warn unused-imports with used generated imports

Brandon Chinn requested to merge brandonchinn178/ghc:wip/chinn/T21730-import into master

Handles issue (1) in #21730. Also includes refactoring to get rid of the srcSpanEnd hack in ImportMap, instead explicitly handling implicit imports in addition to explicitly handling generated imports.

Apologies if CI fails; I keep getting these errors with ./validate --testsuite-only ...:

/var/folders/q2/8xqqr_6j2sdb9w61r65pdn8r0000gr/T/ghc55528_0/ghc_3.s:344:8: error:
     error: unsupported relocation with subtraction expression, symbol '_base_GHCziUnicodeziInternalziCharziUnicodeDataziSimpleUpperCaseMapping_zdwtoSimpleUpperCase_info' can not be undefined in a subtraction expression
            .quad   _base_GHCziUnicodeziInternalziCharziUnicodeDataziSimpleUpperCaseMapping_zdwtoSimpleUpperCase_info-(Ln3Ht)+0
                    ^
    |
344 |         .quad   _base_GHCziUnicodeziInternalziCharziUnicodeDataziSimpleUpperCaseMapping_zdwtoSimpleUpperCase_info-(Ln3Ht)+0
    |        ^

I'm on MacOS:

Platform {platformArchOS = ArchOS {archOS_arch = ArchX86_64, archOS_OS = OSDarwin}, ...}

If someone could provide guidance to fix this, that'd be great. I do see this commit, but this seems to be a different place (that commit handles _closure symbols, but my error is for an _info symbol).

Edited by Brandon Chinn

Merge request reports