Skip to content
Snippets Groups Projects

Add quotRem and quot built-in rules (#22152)

Closed Sylvain Henry requested to merge wip/T22152 into master
  • Commit 1: add quotRem with dead binders rule
  • Commit 2: add rule: (x quot l1) quot l2 ==> x quot (l1*l2)
  • Commit 3: fix 64-bit division primops to make them ok-for-speculation when divisor /= 0, just like the other ones
  • Commit 4: also make WordQuotRem2Op ok-for-speculation
Edited by Sylvain Henry

Merge request reports

Approval is optional
Test summary results are being parsed

Closed by Marge BotMarge Bot 1 year ago (Apr 13, 2023 12:50pm UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sylvain Henry added 148 commits

    added 148 commits

    Compare with previous version

  • Simon Peyton Jones
  • Simon Peyton Jones
  • Simon Peyton Jones
  • 268 277 Int32QuotOp -> mkPrimOpRule nm 2 [ nonZeroLit 1 >> binaryLit (int32Op2 quot)
    • Aren't all of these quot-folding rules? Coudl we move nonZeroLit 1, leftZero, oneLit, equalArgs into quotFoldingRules and reduce all this duplication?

    • Author Developer

      Indeed since we have more primitive types and primops, there is a lot more duplication. We should open a ticket about this as it's not specific to quot primops.

    • Please register or sign in to reply
  • Matthew Craven mentioned in merge request !10097 (closed)

    mentioned in merge request !10097 (closed)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading