Skip to content

Remove source location information from interface files

Owen Shepherd requested to merge 414owen/ghc:os/remove-source-location-binary into master

This change aims to minimize source location information leaking into interface files, which makes ABI hashes dependent on the build location.

The Binary (Located a) instance has been removed completely.

It seems that the HIE interface still needs the ability to serialize SrcSpans, but by moving the instances, it should be a lot more difficult to inadvertently add source location information.

fixes: #22225 (closed)

Please take a few moments to verify that your commits fulfill the following:

  • are either individually buildable or squashed
  • have commit messages which describe what they do (referring to [Notes][notes] and tickets using #NNNN syntax when appropriate)
  • have added source comments describing your change. For larger changes you likely should add a [Note][notes] and cross-reference it from the relevant places.
  • add a testcase to the testsuite.
  • if your MR affects library interfaces (e.g. changes base) or affects whether GHC will accept user-written code, please add the ~"user facing" label.
  • updates the users guide if applicable
  • mentions new features in the release notes for the next release

Merge request reports