Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • GHC GHC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 5,242
    • Issues 5,242
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 567
    • Merge requests 567
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Glasgow Haskell CompilerGlasgow Haskell Compiler
  • GHCGHC
  • Merge requests
  • !9568

split req_smp to differentiate between smp support for target and host

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed doyougnu requested to merge wip/req_smp into master Dec 17, 2022
  • Overview 18
  • Commits 1
  • Pipelines 29
  • Changes 16

See #22630 (closed) and !9552

This MR splits the req_smp flag into two: req_target_smp and req_ghc_smp so that the testsuite can differentiate between tests that require smp to build vs tests that require smp to run. This came up while working on !9552, where several tests would unexpectedly pass because the cross compiler is linked with the bootstrapped rts, but the target does not support smp. So the tests would be marked as expected broken, but would still run and still pass.

Marking as draft until CI looks good.

TODOs:

  • CI passes
  • rebase
  • squash
Edited Jan 09, 2023 by doyougnu
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/req_smp