Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • GHC GHC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 5,359
    • Issues 5,359
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 565
    • Merge requests 565
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Glasgow Haskell CompilerGlasgow Haskell Compiler
  • GHCGHC
  • Merge requests
  • !9722

Fix Lint check for duplicate external names

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Krzysztof Gogolewski requested to merge tweag/ghc:wip/fix-lint-duplicates-check into master Jan 16, 2023
  • Overview 8
  • Commits 1
  • Pipelines 3
  • Changes 1

Lint was checking for duplicate external names by calling removeDups, which needs a comparison function that is passed to Data.List.sortBy.

But the comparison was not a valid ordering - it returned LT if one of the names was not external.

For example, the previous implementation won't find a duplicate in [M.x, y, M.x].

Instead, we filter out non-external names before looking for duplicates.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/fix-lint-duplicates-check