... | ... | @@ -4,8 +4,8 @@ In GHC 7.10, we changed the internal representation of names to be based on pack |
|
|
|
|
|
>
|
|
|
>
|
|
|
> [ https://github.com/ekmett/lens/issues/496](https://github.com/ekmett/lens/issues/496)
|
|
|
> [ https://ghc.haskell.org/trac/ghc/ticket/10279](https://ghc.haskell.org/trac/ghc/ticket/10279)
|
|
|
> [https://github.com/ekmett/lens/issues/496](https://github.com/ekmett/lens/issues/496)
|
|
|
> [https://ghc.haskell.org/trac/ghc/ticket/10279](https://ghc.haskell.org/trac/ghc/ticket/10279)
|
|
|
>
|
|
|
>
|
|
|
|
... | ... | @@ -15,9 +15,9 @@ The primary use-case for generating a `Name` from scratch is in order to provide |
|
|
|
|
|
We now propose the following changes to the TH API in order to track these changes. See these tickets for background and motivation
|
|
|
|
|
|
- [\#9265](https://gitlab.haskell.org//ghc/ghc/issues/9265): why move to package keys instead of package names
|
|
|
- [\#10279](https://gitlab.haskell.org//ghc/ghc/issues/10279): breakage caused by faking package keys
|
|
|
- [ Similar lens bug](https://github.com/ekmett/lens/issues/496)
|
|
|
- [\#9265](https://gitlab.haskell.org/ghc/ghc/issues/9265): why move to package keys instead of package names
|
|
|
- [\#10279](https://gitlab.haskell.org/ghc/ghc/issues/10279): breakage caused by faking package keys
|
|
|
- [Similar lens bug](https://github.com/ekmett/lens/issues/496)
|
|
|
|
|
|
## Rename PkgName to UnitId
|
|
|
|
... | ... | @@ -40,7 +40,7 @@ mkUnitId = UnitId |
|
|
**Variation 1.** Keep the old `PkgName` type and constructor around for backwards compatibility. One reason **not** to do this is that the change from package name to package key was a semantic change, meaning that people who were faking keys by concatenating a name with a version had their code break. (On the other hand, by the end of the 7.10 cycle most people probably will be using the old name correctly.)
|
|
|
|
|
|
|
|
|
Here is the GitHub search for uses of `NameG`, which usually indicates a package key is being manipulated directly: [ https://github.com/search?l=haskell&q=NameG&type=Code&utf8=%E2%9C%93](https://github.com/search?l=haskell&q=NameG&type=Code&utf8=%E2%9C%93)
|
|
|
Here is the GitHub search for uses of `NameG`, which usually indicates a package key is being manipulated directly: [https://github.com/search?l=haskell&q=NameG&type=Code&utf8=%E2%9C%93](https://github.com/search?l=haskell&q=NameG&type=Code&utf8=%E2%9C%93)
|
|
|
|
|
|
## Querying about units
|
|
|
|
... | ... | |