• David Eichmann's avatar
    Fix unused-import warnings · 6353efc7
    David Eichmann authored
    This patch fixes a fairly long-standing bug (dating back to 2015) in
    RdrName.bestImport, namely
    
       commit 9376249b
       Author: Simon Peyton Jones <simonpj@microsoft.com>
       Date:   Wed Oct 28 17:16:55 2015 +0000
    
       Fix unused-import stuff in a better way
    
    In that patch got the sense of the comparison back to front, and
    thereby failed to implement the unused-import rules described in
      Note [Choosing the best import declaration] in RdrName
    
    This led to Trac #13064 and #15393
    
    Fixing this bug revealed a bunch of unused imports in libraries;
    the ones in the GHC repo are part of this commit.
    
    The two important changes are
    
    * Fix the bug in bestImport
    
    * Modified the rules by adding (a) in
         Note [Choosing the best import declaration] in RdrName
      Reason: the previosu rules made Trac #5211 go bad again.  And
      the new rule (a) makes sense to me.
    
    In unravalling this I also ended up doing a few other things
    
    * Refactor RnNames.ImportDeclUsage to use a [GlobalRdrElt] for the
      things that are used, rather than [AvailInfo]. This is simpler
      and more direct.
    
    * Rename greParentName to greParent_maybe, to follow GHC
      naming conventions
    
    * Delete dead code RdrName.greUsedRdrName
    
    Bumps a few submodules.
    
    Reviewers: hvr, goldfire, bgamari, simonmar, jrtc27
    
    Subscribers: rwbarton, carter
    
    Differential Revision: https://phabricator.haskell.org/D5312
    6353efc7
Name
Last commit
Last update
..
base01 Loading commit data...
mod175 Loading commit data...
Makefile Loading commit data...
Mod101_AuxA.hs Loading commit data...
Mod101_AuxB.hs Loading commit data...
Mod102_AuxA.hs Loading commit data...
Mod102_AuxB.hs Loading commit data...
Mod114_Help.hs Loading commit data...
Mod115_A.hs Loading commit data...
Mod115_B.hs Loading commit data...
Mod117_A.hs Loading commit data...
Mod117_B.hs Loading commit data...
Mod118_A.hs Loading commit data...
Mod118_B.hs Loading commit data...
Mod119_A.hs Loading commit data...
Mod119_B.hs Loading commit data...
Mod120_A.hs Loading commit data...
Mod121_A.hs Loading commit data...
Mod122_A.hs Loading commit data...
Mod123_A.hs Loading commit data...
Mod124_A.hs Loading commit data...
Mod125_A.hs Loading commit data...
Mod126_A.hs Loading commit data...
Mod127_A.hs Loading commit data...
Mod128_A.hs Loading commit data...
Mod131_A.hs Loading commit data...
Mod131_B.hs Loading commit data...
Mod132_A.hs Loading commit data...
Mod132_B.hs Loading commit data...
Mod136_A.hs Loading commit data...
Mod137_A.hs Loading commit data...
Mod138_A.hs Loading commit data...
Mod139_A.hs Loading commit data...
Mod139_B.hs Loading commit data...
Mod140_A.hs Loading commit data...
Mod141_A.hs Loading commit data...
Mod142_A.hs Loading commit data...
Mod143_A.hs Loading commit data...
Mod144_A.hs Loading commit data...
Mod145_A.hs Loading commit data...
Mod147_A.hs Loading commit data...
Mod157_A.hs Loading commit data...
Mod157_B.hs Loading commit data...
Mod157_C.hs Loading commit data...
Mod157_D.hs Loading commit data...
Mod159_A.hs Loading commit data...
Mod159_B.hs Loading commit data...
Mod159_C.hs Loading commit data...
Mod159_D.hs Loading commit data...
Mod162_A.hs Loading commit data...
Mod163_A.hs Loading commit data...
Mod164_A.hs Loading commit data...
Mod164_B.hs Loading commit data...
Mod170_A.hs Loading commit data...
Mod171_A.hs Loading commit data...
Mod171_B.hs Loading commit data...
Mod172_B.hs Loading commit data...
Mod172_C.hs Loading commit data...
Mod173_Aux.hs Loading commit data...
Mod178_2.hs Loading commit data...
Mod179_A.hs Loading commit data...
Mod180_A.hs Loading commit data...
Mod180_B.hs Loading commit data...
MultiExport.hs Loading commit data...
MultiExport.stderr Loading commit data...
T10233.hs Loading commit data...
T10233a.hs Loading commit data...
T1074.hs Loading commit data...
T1074.stderr Loading commit data...
T1074a.hs Loading commit data...
T11432.hs Loading commit data...
T11432.stderr Loading commit data...
T11432a.hs Loading commit data...
T11432a.stderr Loading commit data...
T1148.hs Loading commit data...
T11970.hs Loading commit data...
T11970.stderr Loading commit data...
T11970A.hs Loading commit data...
T11970A.stderr Loading commit data...
T11970A1.hs Loading commit data...
T11970B.hs Loading commit data...
T11970B.stderr Loading commit data...
T12026.hs Loading commit data...
T12026.stderr Loading commit data...
T13528.hs Loading commit data...
T13622.hs Loading commit data...
T13704a.hs Loading commit data...
T13704b1.hs Loading commit data...
T13704b2.hs Loading commit data...
T2267.hs Loading commit data...
T3776.hs Loading commit data...
T414.hs Loading commit data...
T414.stderr Loading commit data...
T414a.hs Loading commit data...
T414b.hs Loading commit data...
T7765.hs Loading commit data...
T7765.stderr Loading commit data...
T9061.hs Loading commit data...
T9997.hs Loading commit data...
all.T Loading commit data...
convert-tests.sh Loading commit data...
mod1.hs Loading commit data...
mod1.stderr Loading commit data...
mod10.hs Loading commit data...
mod10.stderr Loading commit data...
mod100.hs Loading commit data...
mod101.hs Loading commit data...
mod101.stderr Loading commit data...
mod102.hs Loading commit data...
mod102.stderr Loading commit data...
mod103.hs Loading commit data...
mod104.hs Loading commit data...
mod105.hs Loading commit data...
mod106.hs Loading commit data...
mod107.hs Loading commit data...
mod108.hs Loading commit data...
mod109.hs Loading commit data...
mod11.hs Loading commit data...
mod110.hs Loading commit data...
mod110.stderr Loading commit data...
mod111.hs Loading commit data...
mod112.hs Loading commit data...
mod113.hs Loading commit data...
mod114.hs Loading commit data...
mod114.stderr Loading commit data...
mod115.hs Loading commit data...
mod116.hs Loading commit data...
mod116.stderr Loading commit data...
mod117.hs Loading commit data...
mod118.hs Loading commit data...
mod119.hs Loading commit data...
mod12.hs Loading commit data...
mod120.hs Loading commit data...
mod120.stderr Loading commit data...
mod121.hs Loading commit data...
mod121.stderr Loading commit data...
mod122.hs Loading commit data...
mod122.stderr Loading commit data...
mod123.hs Loading commit data...
mod123.stderr Loading commit data...
mod124.hs Loading commit data...
mod124.stderr Loading commit data...
mod125.hs Loading commit data...
mod125.stderr Loading commit data...
mod126.hs Loading commit data...
mod126.stderr Loading commit data...
mod127.hs Loading commit data...
mod127.stderr Loading commit data...
mod128.hs Loading commit data...
mod128.stderr Loading commit data...
mod129.hs Loading commit data...
mod13.hs Loading commit data...
mod130.hs Loading commit data...
mod130.stderr Loading commit data...
mod131.hs Loading commit data...
mod131.stderr Loading commit data...
mod132.hs Loading commit data...
mod132.stderr Loading commit data...
mod133.hs Loading commit data...
mod134.hs Loading commit data...
mod134.stderr Loading commit data...
mod135.hs Loading commit data...
mod135.stderr Loading commit data...
mod136.hs Loading commit data...
mod136.stderr Loading commit data...
mod137.hs Loading commit data...
mod138.hs Loading commit data...
mod138.stderr Loading commit data...
mod139.hs Loading commit data...
mod14.hs Loading commit data...
mod14.stderr Loading commit data...
mod140.hs Loading commit data...
mod141.hs Loading commit data...
mod142.hs Loading commit data...
mod142.stderr Loading commit data...
mod143.hs Loading commit data...
mod143.stderr Loading commit data...
mod144.hs Loading commit data...
mod144.stderr Loading commit data...
mod145.hs Loading commit data...
mod145.stderr Loading commit data...
mod146.hs Loading commit data...
mod146.stderr Loading commit data...
mod147.hs Loading commit data...
mod147.stderr Loading commit data...
mod148.hs Loading commit data...
mod149.hs Loading commit data...
mod15.hs Loading commit data...
mod150.hs Loading commit data...
mod150.stderr Loading commit data...
mod151.hs Loading commit data...
mod151.stderr Loading commit data...
mod152.hs Loading commit data...
mod152.stderr Loading commit data...
mod153.hs Loading commit data...
mod153.stderr Loading commit data...
mod154.hs Loading commit data...
mod155.hs Loading commit data...
mod155.stderr Loading commit data...
mod156.hs Loading commit data...
mod157.hs Loading commit data...
mod158.hs Loading commit data...
mod158.stderr Loading commit data...
mod159.hs Loading commit data...
mod16.hs Loading commit data...
mod160.hs Loading commit data...
mod160.stderr Loading commit data...
mod161.hs Loading commit data...
mod161.stderr Loading commit data...
mod162.hs Loading commit data...
mod163.hs Loading commit data...
mod164.hs Loading commit data...
mod164.stderr Loading commit data...
mod165.hs Loading commit data...
mod165.stderr Loading commit data...
mod166.hs Loading commit data...
mod167.hs Loading commit data...
mod168.hs Loading commit data...
mod169.hs Loading commit data...
mod17.hs Loading commit data...
mod17.stderr Loading commit data...
mod170.hs Loading commit data...
mod171.hs Loading commit data...
mod172.hs Loading commit data...
mod173.hs Loading commit data...
mod176.hs Loading commit data...
mod176.stderr Loading commit data...
mod177.hs Loading commit data...
mod177.stderr Loading commit data...
mod178.hs Loading commit data...
mod178.stderr Loading commit data...
mod179.hs Loading commit data...
mod179.stdout Loading commit data...
mod18.hs Loading commit data...
mod18.stderr Loading commit data...
mod180.hs Loading commit data...
mod180.stderr Loading commit data...
mod19.hs Loading commit data...
mod19.stderr Loading commit data...
mod2.hs Loading commit data...
mod2.stderr Loading commit data...
mod20.hs Loading commit data...
mod20.stderr Loading commit data...
mod21.hs Loading commit data...
mod21.stderr Loading commit data...
mod22.hs Loading commit data...
mod22.stderr Loading commit data...
mod23.hs Loading commit data...
mod23.stderr Loading commit data...
mod24.hs Loading commit data...
mod24.stderr Loading commit data...
mod25.hs Loading commit data...
mod25.stderr Loading commit data...
mod26.hs Loading commit data...
mod26.stderr Loading commit data...
mod27.hs Loading commit data...
mod27.stderr Loading commit data...
mod29.hs Loading commit data...
mod29.stderr Loading commit data...
mod3.hs Loading commit data...
mod3.stderr Loading commit data...
mod30.hs Loading commit data...
mod31.hs Loading commit data...
mod32.hs Loading commit data...
mod33.hs Loading commit data...
mod34.hs Loading commit data...
mod35.hs Loading commit data...
mod36.hs Loading commit data...
mod36.stderr Loading commit data...
mod37.hs Loading commit data...
mod38.hs Loading commit data...
mod38.stderr Loading commit data...
mod39.hs Loading commit data...
mod39.stderr Loading commit data...
mod4.hs Loading commit data...
mod4.stderr Loading commit data...
mod40.hs Loading commit data...
mod40.stderr Loading commit data...
mod41.hs Loading commit data...
mod41.stderr Loading commit data...
mod42.hs Loading commit data...
mod42.stderr Loading commit data...
mod43.hs Loading commit data...
mod43.stderr Loading commit data...
mod44.hs Loading commit data...
mod44.stderr Loading commit data...
mod45.hs Loading commit data...
mod45.stderr Loading commit data...
mod46.hs Loading commit data...
mod46.stderr Loading commit data...
mod47.hs Loading commit data...
mod47.stderr Loading commit data...
mod48.hs Loading commit data...
mod48.stderr Loading commit data...
mod49.hs Loading commit data...
mod49.stderr Loading commit data...
mod5.hs Loading commit data...
mod5.stderr Loading commit data...
mod50.hs Loading commit data...
mod50.stderr Loading commit data...
mod51.hs Loading commit data...
mod51.stderr Loading commit data...
mod52.hs Loading commit data...
mod52.stderr Loading commit data...
mod53.hs Loading commit data...
mod53.stderr Loading commit data...
mod54.hs Loading commit data...
mod54.stderr Loading commit data...
mod55.hs Loading commit data...
mod55.stderr Loading commit data...
mod56.hs Loading commit data...
mod56.stderr Loading commit data...
mod58.hs Loading commit data...
mod58.stderr Loading commit data...
mod59.hs Loading commit data...
mod59.stderr Loading commit data...
mod6.hs Loading commit data...
mod60.hs Loading commit data...
mod60.stderr Loading commit data...
mod61.hs Loading commit data...
mod61.stderr Loading commit data...
mod62.hs Loading commit data...
mod62.stderr Loading commit data...
mod63.hs Loading commit data...
mod63.stderr Loading commit data...
mod64.hs Loading commit data...
mod65.hs Loading commit data...
mod66.hs Loading commit data...
mod66.stderr Loading commit data...
mod67.hs Loading commit data...
mod67.stderr Loading commit data...
mod68.hs Loading commit data...
mod68.stderr Loading commit data...
mod69.hs Loading commit data...
mod69.stderr Loading commit data...
mod7.hs Loading commit data...
mod7.stderr Loading commit data...
mod70.hs Loading commit data...
mod70.stderr Loading commit data...
mod71.hs Loading commit data...
mod71.stderr Loading commit data...
mod72.hs Loading commit data...
mod72.stderr Loading commit data...
mod73.hs Loading commit data...
mod73.stderr Loading commit data...
mod74.hs Loading commit data...
mod74.stderr Loading commit data...
mod75.hs Loading commit data...
mod76.hs Loading commit data...
mod76.stderr Loading commit data...
mod77.hs Loading commit data...
mod77.stderr Loading commit data...
mod79.hs Loading commit data...
mod79.stderr Loading commit data...
mod8.hs Loading commit data...
mod8.stderr Loading commit data...
mod80.hs Loading commit data...
mod80.stderr Loading commit data...
mod81.hs Loading commit data...
mod81.stderr Loading commit data...
mod82.hs Loading commit data...
mod83.hs Loading commit data...
mod84.hs Loading commit data...
mod85.hs Loading commit data...
mod86.hs Loading commit data...
mod87.hs Loading commit data...
mod87.stderr Loading commit data...
mod88.hs Loading commit data...
mod88.stderr Loading commit data...
mod89.hs Loading commit data...
mod89.stderr Loading commit data...
mod9.hs Loading commit data...
mod9.stderr Loading commit data...
mod90.hs Loading commit data...
mod90.stderr Loading commit data...
mod91.hs Loading commit data...
mod91.stderr Loading commit data...
mod92.hs Loading commit data...
mod93.hs Loading commit data...
mod94.hs Loading commit data...
mod95.hs Loading commit data...
mod96.hs Loading commit data...
mod97.hs Loading commit data...
mod97.stderr Loading commit data...
mod98.hs Loading commit data...
mod98.stderr Loading commit data...
mod99.hs Loading commit data...