Skip to content

Build of `banner` broken because of `foldr1` apparently has been added to Prelude

While benchmarking on HEAD, I got the following error:

== make all --no-print-directory;
 in /M5504/nofib/spectral/banner
------------------------------------------------------------------------
HC = /M5504/inplace/bin/ghc-stage2
HC_OPTS = -O2 -Wno-tabs -Rghc-timing -H32m -hisuf hi -rtsopts
RUNTEST_OPTS = -ghc-timing +RTS -V0 -RTS -cachegrind
==nofib== banner: time to compile Main follows...
/M5504/inplace/bin/ghc-stage2 -O2 -Wno-tabs -Rghc-timing -H32m -hisuf hi -rtsopts -c Main.hs -o Main.o

Main.hs:41:23: error:
    Ambiguous occurrence ‘foldr1’
    It could refer to
       either ‘Prelude.foldr1’,
              imported from ‘Prelude’ at Main.hs:1:1
              (and originally defined in ‘Data.Foldable’)
           or ‘Data.List.foldr1’,
              imported from ‘Data.List’ at Main.hs:32:1-16
              (and originally defined in ‘GHC.List’)
   |
41 |         where join  = foldr1 (\xs ys -> xs ++ "  " ++ ys)
   |                       ^^^^^^

So we probably need to update banner. Not sure what is the best fix; it should better be backwards-compatible.