Skip to content
  • Suganya Raju's avatar
    667be468
    Cabal Error Refactor (#9018) · 667be468
    Suganya Raju authored
    
    
    * I have added a function "dieWithException" which will replace the die' calls and throws Error types as exception.
    CabalException will hold all ErrorTypes, types will be incrementally added per module.
    The VerboseException a will have CabalException and cabalInstallException variously in the a position
    
    Utils.hs
    1. Creation of Error data types
    2. Diewithexception and exceptionCode function
    3. Instance for VerboseException
    
    Bench.hs and install.hs
    1. Replaced die' call sites with dieWithException
    
    Right now I have only added errors from two modules Distribtuion/Simple/Bench and Distribution/Simple/Install. Error types will be added incrementally.
    
    * Codebase is formatted with fourmolu and compiled without warnings.
    
    * Enabled fourmolu action
    
    * Running fourmolu through github action as the previous ones failed.
    
    * Function `exceptionWithMetadata` and constructors for each exception type
    
    * I have added a function "dieWithException" which will replace the die' calls and throws Error types as exception.
    CabalException will hold all ErrorTypes, types will be incrementally added per module.
    The VerboseException a will have CabalException and cabalInstallException variously in the a position
    
    Utils.hs
    1. Creation of Error data types
    2. Diewithexception and exceptionCode function
    3. Instance for VerboseException
    
    Bench.hs and install.hs
    1. Replaced die' call sites with dieWithException
    
    Right now I have only added errors from two modules Distribtuion/Simple/Bench and Distribution/Simple/Install. Error types will be added incrementally.
    
    * Codebase is formatted with fourmolu and compiled without warnings.
    
    * Enabled fourmolu action
    
    * Running fourmolu through github action as the previous ones failed.
    
    * Function `exceptionWithMetadata` and constructors for each exception type
    
    * Updated changelog
    
    * PatternMatching cases of diewithexception and displayexception reduced
    
    * Delete fourmolu.yaml
    
    This file is redundant.
    
    * Delete settings.json
    
    This file is redundant.
    
    * Replaced die' calls for modules srcDist.hs and HcPkg.hs
    
    * Replaced die' calls in modules `build.hs`,`Haddock.hs` and `Program.hs`
    
    * Replaced die' calls in modules `Build.hs`, `Haddock.hs` and `Program.hs`
    
    * Replaced die' calls in modules `GHCJS.hs`, `HaskellSuite.hs` and `BuildPaths.hs`
    
    * Formatted the codebase with Fourmolu
    
    * Accepted the new output with error codes and adding the file relevant to the test
    
    * Changes in `Utils.hs` and `Errors.hs` to reflect the new error codes
    
    * Keeping rip intact
    
    * test changes
    
    * CallStack unmarked from the error output
    
    * callstack unmarked from output
    
    * unmarked callstack in test output
    
    * Format the codebase with fourmolu
    
    * Changed to Error identifier to "Cabal-"
    
    * Updated Constructors as per review comments
    
    * Rectifying Hlint warning
    
    ---------
    
    Co-authored-by: default avatarGershom Bazerman <gershom@arista.com>
    667be468
    Cabal Error Refactor (#9018)
    Suganya Raju authored
    
    
    * I have added a function "dieWithException" which will replace the die' calls and throws Error types as exception.
    CabalException will hold all ErrorTypes, types will be incrementally added per module.
    The VerboseException a will have CabalException and cabalInstallException variously in the a position
    
    Utils.hs
    1. Creation of Error data types
    2. Diewithexception and exceptionCode function
    3. Instance for VerboseException
    
    Bench.hs and install.hs
    1. Replaced die' call sites with dieWithException
    
    Right now I have only added errors from two modules Distribtuion/Simple/Bench and Distribution/Simple/Install. Error types will be added incrementally.
    
    * Codebase is formatted with fourmolu and compiled without warnings.
    
    * Enabled fourmolu action
    
    * Running fourmolu through github action as the previous ones failed.
    
    * Function `exceptionWithMetadata` and constructors for each exception type
    
    * I have added a function "dieWithException" which will replace the die' calls and throws Error types as exception.
    CabalException will hold all ErrorTypes, types will be incrementally added per module.
    The VerboseException a will have CabalException and cabalInstallException variously in the a position
    
    Utils.hs
    1. Creation of Error data types
    2. Diewithexception and exceptionCode function
    3. Instance for VerboseException
    
    Bench.hs and install.hs
    1. Replaced die' call sites with dieWithException
    
    Right now I have only added errors from two modules Distribtuion/Simple/Bench and Distribution/Simple/Install. Error types will be added incrementally.
    
    * Codebase is formatted with fourmolu and compiled without warnings.
    
    * Enabled fourmolu action
    
    * Running fourmolu through github action as the previous ones failed.
    
    * Function `exceptionWithMetadata` and constructors for each exception type
    
    * Updated changelog
    
    * PatternMatching cases of diewithexception and displayexception reduced
    
    * Delete fourmolu.yaml
    
    This file is redundant.
    
    * Delete settings.json
    
    This file is redundant.
    
    * Replaced die' calls for modules srcDist.hs and HcPkg.hs
    
    * Replaced die' calls in modules `build.hs`,`Haddock.hs` and `Program.hs`
    
    * Replaced die' calls in modules `Build.hs`, `Haddock.hs` and `Program.hs`
    
    * Replaced die' calls in modules `GHCJS.hs`, `HaskellSuite.hs` and `BuildPaths.hs`
    
    * Formatted the codebase with Fourmolu
    
    * Accepted the new output with error codes and adding the file relevant to the test
    
    * Changes in `Utils.hs` and `Errors.hs` to reflect the new error codes
    
    * Keeping rip intact
    
    * test changes
    
    * CallStack unmarked from the error output
    
    * callstack unmarked from output
    
    * unmarked callstack in test output
    
    * Format the codebase with fourmolu
    
    * Changed to Error identifier to "Cabal-"
    
    * Updated Constructors as per review comments
    
    * Rectifying Hlint warning
    
    ---------
    
    Co-authored-by: default avatarGershom Bazerman <gershom@arista.com>
Loading