Fix extra-prog-path propagation in the codebase.
Extra prog paths were being handled in many different ways all thorugh the codebase. This PR introduces a unified way to look at them. Aiming for traceability, the addition of extra paths is now traced via `logExtraProgramSearchPath`. All appearances of `modifyProgramSearchPath` are replaced with `appendProgramSearchPath` which traces the added paths. `progInvokePathEnv` was only being set by GHC for some paths to executables in components and only under certain circumstances. Now every `ghcInvocation` sets the extra paths directly into `pkgInvokeEnv`. In particular this fixes PATH issues when running MinGW cabal in PowerShell, as usually for other OSes the system path contains most of the expected directories.
Showing
- Cabal/src/Distribution/Simple/Configure.hs 16 additions, 17 deletionsCabal/src/Distribution/Simple/Configure.hs
- Cabal/src/Distribution/Simple/ConfigureScript.hs 1 addition, 4 deletionsCabal/src/Distribution/Simple/ConfigureScript.hs
- Cabal/src/Distribution/Simple/GHC.hs 3 additions, 1 deletionCabal/src/Distribution/Simple/GHC.hs
- Cabal/src/Distribution/Simple/GHCJS.hs 1 addition, 1 deletionCabal/src/Distribution/Simple/GHCJS.hs
- Cabal/src/Distribution/Simple/Program/Db.hs 16 additions, 0 deletionsCabal/src/Distribution/Simple/Program/Db.hs
- Cabal/src/Distribution/Simple/Program/Find.hs 30 additions, 0 deletionsCabal/src/Distribution/Simple/Program/Find.hs
- Cabal/src/Distribution/Simple/Program/GHC.hs 14 additions, 9 deletionsCabal/src/Distribution/Simple/Program/GHC.hs
- Cabal/src/Distribution/Simple/Program/Run.hs 3 additions, 26 deletionsCabal/src/Distribution/Simple/Program/Run.hs
- Cabal/src/Distribution/Simple/Program/Types.hs 7 additions, 0 deletionsCabal/src/Distribution/Simple/Program/Types.hs
- cabal-install/src/Distribution/Client/CmdExec.hs 26 additions, 19 deletionscabal-install/src/Distribution/Client/CmdExec.hs
- cabal-install/src/Distribution/Client/CmdInstall.hs 6 additions, 12 deletionscabal-install/src/Distribution/Client/CmdInstall.hs
- cabal-install/src/Distribution/Client/CmdRun.hs 28 additions, 3 deletionscabal-install/src/Distribution/Client/CmdRun.hs
- cabal-install/src/Distribution/Client/Config.hs 8 additions, 0 deletionscabal-install/src/Distribution/Client/Config.hs
- cabal-install/src/Distribution/Client/Get.hs 9 additions, 3 deletionscabal-install/src/Distribution/Client/Get.hs
- cabal-install/src/Distribution/Client/HttpUtils.hs 3 additions, 4 deletionscabal-install/src/Distribution/Client/HttpUtils.hs
- cabal-install/src/Distribution/Client/ProjectConfig.hs 2 additions, 3 deletionscabal-install/src/Distribution/Client/ProjectConfig.hs
- cabal-install/src/Distribution/Client/ProjectOrchestration.hs 1 addition, 1 deletion...l-install/src/Distribution/Client/ProjectOrchestration.hs
- cabal-install/src/Distribution/Client/ProjectPlanning.hs 5 additions, 12 deletionscabal-install/src/Distribution/Client/ProjectPlanning.hs
- cabal-install/src/Distribution/Client/SetupWrapper.hs 8 additions, 6 deletionscabal-install/src/Distribution/Client/SetupWrapper.hs
- cabal-install/src/Distribution/Client/VCS.hs 11 additions, 3 deletionscabal-install/src/Distribution/Client/VCS.hs
Loading