Skip to content
Snippets Groups Projects
Unverified Commit 5d43746f authored by Jappie Klooster's avatar Jappie Klooster Committed by GitHub
Browse files

Add upper bound check to all (#8361)

* Add check for upper bound on any package

fixes https://github.com/haskell/cabal/issues/8291
presumably this will make it nag at anyone for forgetting
to add upper bounds to their packages.

add changelog

(presumably)

wait what?

move toDependencyVersionsMap to utils section

add nicer error message

simplify checking logic, add more comments

only emit missing upper bounds if bigger then one

don't add bound to internal libraries

filter out self from the dependency map

I think this is an external library so it needs an upper bound now?

add test for multilib

fix test suite by ignoring the warning

... probably not the best approach

change link to pvp instead of parsonsmatt

better wording on missing upper bound error

remove spurious parenthesis

change map creation from monad to list comprehension

use foldmap to get rid of maybe, fix compile error

rewrite from do notation to list comprehension

fix test suite failing

fix compile error

factor out double filter call in a && expression

* set expectation

* Modify test so it gives a list of expected libs

rename public-multilib-3 to all-upper-bound
the test had little to do with multilib.

* Update comment on ignoring warnigns

* use map instead of if

* Undo map change

add comment on why that doesn't work

* Add description and maintainer fields

* make description longer then synopsis in all-upper-bound.cabal
parent 41d60008
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment