Be more careful about ComponentId versus UnitId.
Two big ideas:
* @--dependency@ takes a ComponentId, not UnitId.
I used to think it should be a UnitId but it is
now clear that you want to finger the indefinite
unit id, which can be uniquely identified with
a ComponentId
* When hashing for an InstalledPackageId in
new-build, we should produce a ComponentId,
not a UnitId.
While cleaning up the results, for any codepaths which we don't plan on
implementing Backpack (Distribution.Client.Install, I'm looking at you),
just coerce ComponentId into UnitIds as necessary.
Signed-off-by:
Edward Z. Yang <ezyang@cs.stanford.edu>
Showing
- Cabal/Distribution/InstalledPackageInfo.hs 3 additions, 0 deletionsCabal/Distribution/InstalledPackageInfo.hs
- Cabal/Distribution/Package.hs 1 addition, 1 deletionCabal/Distribution/Package.hs
- Cabal/Distribution/Simple/Configure.hs 13 additions, 13 deletionsCabal/Distribution/Simple/Configure.hs
- Cabal/Distribution/Simple/PackageIndex.hs 10 additions, 2 deletionsCabal/Distribution/Simple/PackageIndex.hs
- Cabal/Distribution/Simple/Setup.hs 3 additions, 3 deletionsCabal/Distribution/Simple/Setup.hs
- cabal-install/Distribution/Client/Configure.hs 4 additions, 4 deletionscabal-install/Distribution/Client/Configure.hs
- cabal-install/Distribution/Client/Install.hs 22 additions, 23 deletionscabal-install/Distribution/Client/Install.hs
- cabal-install/Distribution/Client/InstallPlan.hs 2 additions, 5 deletionscabal-install/Distribution/Client/InstallPlan.hs
- cabal-install/Distribution/Client/PackageHash.hs 3 additions, 3 deletionscabal-install/Distribution/Client/PackageHash.hs
- cabal-install/Distribution/Client/ProjectBuilding.hs 17 additions, 17 deletionscabal-install/Distribution/Client/ProjectBuilding.hs
- cabal-install/Distribution/Client/ProjectOrchestration.hs 8 additions, 9 deletionscabal-install/Distribution/Client/ProjectOrchestration.hs
- cabal-install/Distribution/Client/ProjectPlanOutput.hs 3 additions, 2 deletionscabal-install/Distribution/Client/ProjectPlanOutput.hs
- cabal-install/Distribution/Client/ProjectPlanning.hs 30 additions, 28 deletionscabal-install/Distribution/Client/ProjectPlanning.hs
- cabal-install/Distribution/Client/ProjectPlanning/Types.hs 12 additions, 11 deletionscabal-install/Distribution/Client/ProjectPlanning/Types.hs
- cabal-install/Distribution/Client/SetupWrapper.hs 11 additions, 10 deletionscabal-install/Distribution/Client/SetupWrapper.hs
- cabal-install/Distribution/Client/Types.hs 25 additions, 21 deletionscabal-install/Distribution/Client/Types.hs
Loading
Please register or sign in to comment