Skip to content
Snippets Groups Projects
Commit bd7e2310 authored by Edward Z. Yang's avatar Edward Z. Yang
Browse files

Be more careful about ComponentId versus UnitId.


Two big ideas:

    * @--dependency@ takes a ComponentId, not UnitId.
      I used to think it should be a UnitId but it is
      now clear that you want to finger the indefinite
      unit id, which can be uniquely identified with
      a ComponentId

    * When hashing for an InstalledPackageId in
      new-build, we should produce a ComponentId,
      not a UnitId.

While cleaning up the results, for any codepaths which we don't plan on
implementing Backpack (Distribution.Client.Install, I'm looking at you),
just coerce ComponentId into UnitIds as necessary.

Signed-off-by: default avatarEdward Z. Yang <ezyang@cs.stanford.edu>
parent 6764810d
No related branches found
No related tags found
No related merge requests found
Showing
with 167 additions and 152 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment