Fix repl discarding --build-depends (#8732)
* Fix repl discarding `build-depends` argument
Previously the function `\f -> L.allCondTrees $ traverseCondTreeC f` was
used to add the dependencies, but manipulating `CondTree` this way does
not update the nested fields `targetBuildDepends` of the tree, only the
conditions. It worked merely by chance if one does not further process
these fields: this explains why options like `--allow-newer` or
`allow-older` were incompatible with `--build-depends`.
Using `L.traverseBuildInfos . L.targetBuildDepends` ensures
`targetBuildDepends` fields and conditions are all updated consistently.
* Add test
* Add changelog
* Cleanup
---------
Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Showing
- Cabal-syntax/src/Distribution/Types/GenericPackageDescription.hs 1 addition, 3 deletions...yntax/src/Distribution/Types/GenericPackageDescription.hs
- cabal-install/src/Distribution/Client/CmdRepl.hs 7 additions, 2 deletionscabal-install/src/Distribution/Client/CmdRepl.hs
- cabal-testsuite/PackageTests/ReplBuildDepends/Foo.hs 4 additions, 0 deletionscabal-testsuite/PackageTests/ReplBuildDepends/Foo.hs
- cabal-testsuite/PackageTests/ReplBuildDepends/cabal.allow-newer.out 2 additions, 0 deletions...suite/PackageTests/ReplBuildDepends/cabal.allow-newer.out
- cabal-testsuite/PackageTests/ReplBuildDepends/cabal.allow-older.out 2 additions, 0 deletions...suite/PackageTests/ReplBuildDepends/cabal.allow-older.out
- cabal-testsuite/PackageTests/ReplBuildDepends/cabal.normal.out 2 additions, 0 deletions...-testsuite/PackageTests/ReplBuildDepends/cabal.normal.out
- cabal-testsuite/PackageTests/ReplBuildDepends/cabal.project 1 addition, 0 deletionscabal-testsuite/PackageTests/ReplBuildDepends/cabal.project
- cabal-testsuite/PackageTests/ReplBuildDepends/cabal.test.hs 19 additions, 0 deletionscabal-testsuite/PackageTests/ReplBuildDepends/cabal.test.hs
- cabal-testsuite/PackageTests/ReplBuildDepends/pkg.cabal 7 additions, 0 deletionscabal-testsuite/PackageTests/ReplBuildDepends/pkg.cabal
- changelog.d/pr-8732 10 additions, 0 deletionschangelog.d/pr-8732
Loading