The powershell script contains the password, so writing it to a file
is a bit unsafe. We know pass it via stdin.
This commit also improves the error message for network failures a
little bit.

Passing passwords via command line arguments is insecure: anyone who
is able to read the process list on the system can read the passwords
as well.

For curl, we pass the password via stdin by using the --config option,
which allows us to pass arbitrary additional options via stdin.

Unfortunately, wget's --config option does not support - for stdin. So
we instead use the --input-file option to pass an URI with the password
via stdin.

This fixes an issue in the curl transport when a text response is returned
that doesn't end with a newline from a POST or PUT request. The code expects
the HTTP status code to be on a new line, but that is not the case if the response
doesn't have a trailing new line. We fix this by always printing a new line before
printing the status code. To avoid duplicate new lines, we now strip trailing empty
lines at the end of the response.

This commit refactors the powershell transport to avoid duplication and
also fixes a few problems with it:

* We now run powershell with the ExecutionPolicy bypass, is required when
  the default security policy disallows executing unsigned scripts
  (like our script)
* The powershell script itself has been refactored to behave more like
  curl. In particular, it now prints HTTP status code errors in a nicer
  way instead of failing with a PowerShell Exception + backtrack. We also
  now only print the exception message when we get any other exception,
  since the user is likely not familar with the powershell script at all
  and the other information is thus only confusing and not helpful at all.
* We now handle the case where the server returns some message after a
  POST or a PUT correctly. Previously, that resulted in the raw bytes
  being written to stdout before the HTTP status code, which confused the
  simplistic parser. We now always write the HTTP status code first and
  decode the bytes as UTF8 before sending them to stdout as well.

This will build (if not given as argument) a doc tarball and upload it to
hackage.

Closes #2080

This patch was tested with curl, wget and plain-http, but it's still untested on powershell.
The wget implementation will only work if the available wget supports the `--method` switch.

Set Build-type: Custom

as there now is custom code is Setup.hs

Manual page generation

Refactoring and two Doc/Wording changes

Simplify a few InstallPlan utils, and use setup deps in a few places

When setup deps were introduced "Add ComponentSetup to ComponentDeps", we
kept all uses to be the same old deps, without changing anything by using
those new setup deps. In several places in InstallPlan it makes sense to
use all deps, including setup deps. In fact for InstallPlan we should always
use all deps except in one place: in checking plan validity where we check
for dependency inconsistencies. That's the one place where we look only at
"normal" non-setup deps to check that we're using only one version of each
package.

So for example, with this patch the freeze command now includes setup deps
in the frozen set. The other case that should change is that failures of
deps of packages used only for setup scripts should now be handled properly
because we will look at setup dep edges when looking for things that depend
on a failed package.

Simpler, simpler versions now exist in the InstallPlan module. Those
ones are simpler because they can use the cached Graph.

These are also easy to implement based on the Graph in the InstallPlan.

Not currently used, but will be eventually.

We can calculate this directly on the Graph inside the InstallPlan
rather that using a more complicated algorithm on the PlanIndex.

This patch is primarily motivated by further changes to simplify
and remove dead code from the PlanIndex module.

Use global db in travis

Add some missing extensions to Language.Haskell.Extension

Signed-off-by: Austin Seipp <aseipp@pobox.com>

Migrate integration tests to shell based format, fixed travis

Backwards compatibility type synonym for InstalledPackageId.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

- findExecutable sh
- Use single quotes for cabal exec

bardur.arantsson authored 9 years ago and Oleg Grenrus committed 9 years ago

Fixes #2797

Squashed commits:
- Use ., not source

bardur.arantsson authored 9 years ago and Oleg Grenrus committed 9 years ago

This is required for the reworking of integration tests
to use shell scripts.