Oleg Grenrus authored 1 year ago and f-a committed 1 year ago

This is affect of using indentOfAtLeast method:
any indentation greater than current offset is fine.

That behavior is desirable to parsing multiline field contents,
but it is a bit surprising for fields, which we expect to be aligned.

Such insonsistency seems to be always a mistake, and it's easy to fix once
a machine points it out.

Oleg Grenrus authored 1 year ago and f-a committed 1 year ago

This helps disabling individual packages (e.g. cabal-testsuite)

testsuite: use removeDirectoryRecursiveHack to cleanup

Presumably, should be be more reliable on Windows.

That way we can reuse removeDirectoryRecursiveHack in cabal-testsuite.

Bump actions/download-artifact from 2 to 3

Show full config file contents when option test fails

Add documentation for default-language field

Don't add `extra-prog-path` to `~/.config/cabal/config` (#8951)

(when initially creating it)

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 3.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/v2...v3

)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Documentation cleanup around sublibraries

Or more accurately, clean up documentation of other sections that imply
multilib doesn't exist yet.

Show how to install cabal-head via GHCup

* CONTRIBUTING.md: more description of changelogs

In particular, mention that Markdown is allowed.

* phrasing better

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Specify Fourmolu version

Fourmolu < 0.12 results in spurious suggestions, see #8976.

The password-command option does not parse its value correctly.
Quotes are ignored, making many kinds of commands impossible to
express (e.g.  `sh -c "foo | bar"`).  Also, `cabal user-config`
treats the argument list as a *list of option values*, rather than a
*value that is a list*.  As a consequence, `cabal user-config
update` corrupts the value in the config file.

Fix these issues by parsing the command as a space separated list of
tokens, and changing the getter to `unwords` the value and return a
*singleton* list.  Also update the argument placeholder from
`PASSWORD` to `COMMAND`.

Fixes: https://github.com/haskell/cabal/issues/6268

* Do not check PVP on internal targets

Internal targets: test-suites or benchmarks.
See #8361 for rationale.

Note that this patch is quite ugly (duplicating allBuildInfo, using
list comprehensions, etc.) but we don’t care as everything will be
overwritten by a much more sensible reimplementation in #8427.

* Add changelog for #9004

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Add the ExtendedLiterals extension

Generate cabal-testsuite modules at configure time

Allows to run `cabal repl cabal-testsuite` out of the box.
Enables HLS support for `cabal-testsuite`.

* Deduplicate `LD_LIBRARY_PATH` when running tests

When Cabal runs a test suite, it adds all the dependent libraries to
`LD_LIBRARY_PATH`. In some cases, this can exceed the operating system's
`ARG_MAX` limit:

    dist/build/test/test: createProcess: posix_spawnp: resource exhausted (Argument list too long)

However, many of the entries (observed as high as 75%!) in `LD_LIBRARY_PATH`
are duplicates. Deduplicating the list with `Data.List.nub` fixes this error.

This error was originally observed when testing a large commercial
Haskell project (the mercury.com backend). Ideally, `depLibraryPaths`
would be fixed to not return duplicate entries, but this fixup is
low-cost and effective.

* Add changelog entries

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Fix QuickCheck instance of PackageName to not produce 'all' (fix #8986)

Co-authored-by: Bryan Richter <b@chreekat.net>

Fix #8928 Conclude setup messages with an ellipsis

Also adds ellipsis to lines in *.out files.

Ignore more formatting commits

* Revert workaround to filter JavaScriptFFI out on GHC versions where GHC issue 11214 is fixed.

* Lint

* Lint

* Update version range to reflect the fix being included in GHC 9.8

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Fix typo

American spelling.

* Switch from `show` to `ppPackageCheck`

Show instance for `PackageCheck` is broken (not bijective with `read`) and
in the future will be deprecated.

* Add `warnError`

`warnError` is like `warn`, but instead of "Warning: …" prepends
"Error: …" to the message.  It is useful in those cases where you
want to highlight something is broken but do not want to stop the
program yet.

* cabal check: highlight error messages

Warnings that make `cabal check` fail (i.e. the package will be
refused by Hackage) are prepended by an "Error: " string, like
this:

Error: Instead of 'cc-options: -Llibdir' use 'extra-lib-dirs: libdir'

This commit also gets away from list comprehension.

* Make testsuite pass

`NoDupNames` is now caught with an `error` before check has the opportunity
to run.

* Add changelog for #8908

* Respect concordance

(Artem’s review) summary message will now say “The following errors…”
if the issues are “Error: …”s and “The following warnings…” otherwise.

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>