Fix space leak in ./Setup configure

redundant map after fold

See https://github.com/haskell/cabal/issues/3003#issuecomment-174492371

It uses 'build-type: Simple' now.

Fixes #3003.

Fix bug in solver independent goals.

Add some more backwards-compatibility functions, fixes #3068.

Missing parentheses caused the solver to skip preferring linked packages with
the use of --reorder-goals.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Also rename it to '--documentation'. Note that the shorthand still works.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Distinguish between component ID and unit ID.

Enable tests in setup-dev.sh

It seems there are no longer any spurious failures, so we
can enable tests in setup-dev.sh

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

GHC 8.0 is switching the state sponsored way to specify
linker names from -this-package-key to -this-unit-id, so
it behooves us to use the right one.  But it didn't make
much sense to pass ComponentIds to a flag named UnitId,
so I went ahead and finished a (planned) refactoring
to distinguish ComponentIds from UnitIds.

At the moment, there is NO difference between a ComponentId
and a UnitId; they are identical.  But semantically, a
component ID records what sources/flags we chose (giving us enough
information to typecheck a package), whereas a unit ID records
the component ID as well as how holes were instantiated
(giving us enough information to build it.)  MOST code
in the Cabal library wants unit IDs, but there are a few
places (macros and configuration) where we really do
want a component ID.

Some other refactorings that got caught up in here:

    - Changed the type of componentCompatPackageKey to String, reflecting the
      fact that it's not truly a UnitId or ComponentId.

    - Changed the behavior of CURRENT_PACKAGE_KEY to unconditionally
      give the compatibility package key, which is actually what you
      want if you're using it for the template Haskell trick.  I also
      added a CURRENT_COMPONENT_ID macro for the actual component ID,
      which is something that the Cabal test-suite will find useful.

    - Added the correct feature test for GHC 8.0 ("Uses unit IDs").

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Backpack is going to have to rewrite this functionality.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Change default flag value to True in solver DSL.

Fix typos in solver test case comment.

This default is consistent with Cabal.

[ci skip]

Add dependency-graph information to `printPlan` output

Herbert Valerio Riedel authored 9 years ago and Mikhail Glushenkov committed 9 years ago

This improves the install-plan reporting in `cabal install -v2`'s output
to include reverse-dependencies, thereby giving valuable information why
a package was included in the install-plan to begin with.

Moreover, this also disables line-wrapping for the install-plan for
verbosity `verbose` and greater, to make the output easier to parse
for humans as well as computers

Example output for `cabal install --dry -v2 http-client`:

  In order, the following would be installed:
  base64-bytestring-1.0.0.1 (via: http-client-0.4.11.2) (new package)
  data-default-class-0.0.1 (via: http-client-0.4.11.2 cookie-0.4.1.5) (new package)
  mtl-2.2.1 (via: exceptions-0.8.0.2 parsec-3.1.9) (new package)
  network-2.6.0.2 (via: http-client-0.4.11.2 streaming-commons-0.1.12) (new package)
  old-locale-1.0.0.7 (via: cookie-0.4.1.5) (new package)
  random-1.1 (via: http-client-0.4.11.2 streaming-commons-0.1.12) (new package)
  stm-2.4.4 (via: streaming-commons-0.1.12 exceptions-0.8.0.2) (new package)
  text-1.2.0.4 -integer-simple (via: http-client-0.4.11.2 streaming-commons-0.1.12 parsec-3.1.9 mime-types-0.1.0.6 http-types-0.8.6 case-insensitive-1.2.0.4 hashable-1.2.3.2 cookie-0.4.1.5 blaze-builder-0.4.0.1) (new package)
  blaze-builder-0.4.0.1 (via: http-client-0.4.11.2 streaming-commons-0.1.12 http-types-0.8.6 cookie-0.4.1.5) (new package)
  cookie-0.4.1.5 (via: http-client-0.4.11.2) (new package)
  hashable-1.2.3.2 (via: case-insensitive-1.2.0.4) (new package)
  case-insensitive-1.2.0.4 (via: http-client-0.4.11.2 http-types-0.8.6) (new package)
  http-types-0.8.6 (via: http-client-0.4.11.2) (new package)
  mime-types-0.1.0.6 (via: http-client-0.4.11.2) (new package)
  parsec-3.1.9 (via: network-uri-2.6.0.1) (new package)
  network-uri-2.6.0.1 (via: http-client-0.4.11.2) (new package)
  transformers-compat-0.4.0.4 (via: exceptions-0.8.0.2) (new package)
  exceptions-0.8.0.2 (via: http-client-0.4.11.2) (new package)
  zlib-0.6.1.0 (via: streaming-commons-0.1.12) (new package)
  streaming-commons-0.1.12 (via: http-client-0.4.11.2) (new package)
  http-client-0.4.11.2 (new package)

(cherry picked from commit c0b3c7f1)

Fixes #3054.