This project is mirrored from https://github.com/haskell/Cabal.
Pull mirroring updated .
- Sep 01, 2024
-
-
mergify[bot] authored
CI: validate: don't fail-fast
-
Artem Pelenitsyn authored
Which means that if a Windows job fails, all other jobs in the matrix will be allowed to finish (other platforms, as well as other compilers on Windows, etc.) Inspired by the discussion at https://github.com/haskell/cabal/issues/10263
-
mergify[bot] authored
make sure cabal-install is compatible with Cabal
-
- Aug 31, 2024
-
-
Brandon S. Allbery authored
See https://github.com/haskell/cabal/issues/9833 If a ghc ships with a compatible Cabal, it will be preferred by the solver on `cabal install cabal-install`; the new `cabal-install` should in fact be compatible. So we test this on release branches that have had at least one release on Hackage. (Ideally we'd check ghc instead, but we can't do that from GHA. Even checking Hackage is pretty painful.)
-
mergify[bot] authored
Collection of patches to do with --working-dir
-
- Aug 29, 2024
-
-
Matthew Pickering authored
Before the previous patches this test failed because an incorrect path was passed to hsc2hs (a preprocessor), it now succeeds :)
-
Matthew Pickering authored
When testing `./Setup` only, when `withDirectory` is used, instead of changing into that directory when invoking processes, we now use the `--working-dir` flag and keep a fixed CWD. This will therefore passively test that `--working-dir` is working In addition, it makes it possible to test things easily such as `--working-dir` with a relative path as an argument. `cabal-install` will only invoke `--working-dir` with an absolute path and hence is isolated from any double interpretation issues. Testing against these double interpretation issues is very important as it also prevents over-interpretation of relative paths into absolute paths. Passing absolute paths to tools such as hsc2hs can lead to the build directory leaking into an interface file which leads to non-reproducible results.
-
Matthew Pickering authored
runDbProgram doesn't take into account the working directory (so will normally produce incorrect results when used in `Cabal`). This replaces the last uses which weren't found by testing, they were found by grepping.
-
Matthew Pickering authored
-
Matthew Pickering authored
There are a few places where paths are known to be absolute. This enforces that in the type system by introducing a simple wrapper to `Distribution.Utils.Path`. ``` newtype AbsolutePath (to :: FileOrDir) = AbsolutePath (forall from . SymbolicPath from to) ``` The nice thing about this abstraction is when when a path is unwrapped, due to the universally quantified `from` type, the resulting `SymbolicPath` can be used with any API which expects a path to point `from` a specific directory.
-
Matthew Pickering authored
This refactoring enforces a simple property * We use symbolic paths in Cabal in order to represent that paths to package databases. These paths is relative to the package root. * We use normal filepaths in cabal-install to represent the path to a package database. These are relative to the current working directory. Paths are explicitly converted from one type to the other at the interface of `cabal-install` and `Cabal`, see `setupHsConfigureArgs` for where this happens. In order to achieve this `PackageDB` is abstracted over what the type of filepaths a specific package db points to. ``` type PackageDBX fp = ... | SpecificPackageDB fp | ... ``` If you are using the Cabal library then you probably want to migrate to use `PackageDBCWD` and `PackageDBStackCWD`. ``` type PackageDBCWD = PackageDBX FilePath type PackageDBStackCWD = [PackageDBCWD] ``` Then at the point where you call commands in the `Cabal` library convert these paths into paths relative to the root of the relevant package. The easiest way to do this is convert any paths into an absolute path. This patch fixes a double interpretation issue when the `--working-dir` option was used and package db paths were offset incorrectly.
-
Matthew Pickering authored
This fixes the --gen-pkg-config to use the symbolic path abstraction, in turn this ensures that we interpret the path appropiately when `--working-dir` is also set.
-
Matthew Pickering authored
This fixes a simple oversight where the flags were passed without updating the `--working-dir` argument appropiately.
-
Matthew Pickering authored
It is only on Cabal 3.13 that the symbolic path abstraction was introduced. On CI we only test with Cabal master so the incorrect bound wasn't picked up.
-
- Aug 28, 2024
-
-
mergify[bot] authored
Include package version in --promised-dependency flag
-
Matthew Pickering authored
In the original implementation of promised dependencies I accidentally left over the hard coded `currentCabalId` in the `configureDependencies` function. This led to several errors happening later when the package name and version would be incorrect if you looked at this field (package arguments are not computed using it), it is used when generating cabal macros and something in the haddock options. The solution is to pass the package version in the `--promised-depenency` flag so the format is now ``` NAME-VER[:COMPONENT_NAME]=CID` ``` rather than ``` NAME[:COMPONENT_NAME]=CID ``` Fixes #10166
-
mergify[bot] authored
add "ready and waiting" Mergify label
-
Brandon S. Allbery authored
The bot can use this to announce PRs that are entering the 2-day waiting period.
-
mergify[bot] authored
update the pinned index-state to get the new `rere`
-
Brandon S. Allbery authored
Without this, #10202 breaks `cabal.project.release` on ghc 9.10.1.
-
- Aug 27, 2024
-
-
mergify[bot] authored
ci: Fix --index-state for hackage roundtrip tests
-
Matthew Pickering authored
As a principle, tests which are required for CI to pass should be reproducible and not depending on external resources changes or being modified. The hackage tests currently violate this by depending on the latest index state from hackage. This is problematic because until the test is fixed all merges into master are blocked. Even though the patches in question have nothing to do with the test. It would be more suitable for a nightly job to run on the latest index and for normal CI to run with a fixed index which is updated periodically in a controlled manner. Fixes #10284
-
Matthew Pickering authored
We need to fix the index-state we test against so a new bad cabal file doesn't take down the CI for everyone. Towards #10284
-
- Aug 26, 2024
-
-
Alberto Fanton authored
* Add ProjectRootUsability datatype * Make findProjectRoot aware of broken files * Add changelog entry * Fix typos
-
- Aug 25, 2024
-
-
mergify[bot] authored
tests: Make structured hash tests invariant to GHC version
-
Matthew Pickering authored
In 9.8 the Generic instance for tuples changed (see ghc/ghc#24291) for more details. Therefore we remove the dependency on the `Generic` instance and the hashes will be invariant across GHC versions (for now). Fixes #10269
-
- Aug 24, 2024
-
-
mergify[bot] authored
validate dependabot configuration
-
Brandon S. Allbery authored
Borrowed from Ubuntu (https://github.com/ubuntu/authd/commit/3f9df8f21d952cd33fd44d3834d0edeec1f5766f) Sadly, this won't check our existing config unless I make a dummy update.
-
Brandon S. Allbery authored
* implement mergify rules for release branches We only handled the case of backports previously, but the current release checklist expects that we can commit PRs to release branches during a release (e.g. changelogs, because we want the list of changelog.d files that are actually part of the release). * block merging if PR has a 'blocked:' label * update backports strategy for #10260 --------- Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
mergify[bot] authored
Ignore VSCodium work directory
-
Brandon S. Allbery authored
-
- Aug 23, 2024
-
-
Francesco Gazzetta authored
Release: https://codeberg.org/fgaz/changelog-d/releases/tag/v1.0.1 Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
- Aug 22, 2024
-
-
mergify[bot] authored
index Paths and Paths_ (resp. for PackageInfo)
-
Brandon S. Allbery authored
These can currently be found by searching the documentation for `Paths_pkgname` and `PackageInfo_pkgname`, but you pretty much need to know that to begin with to find them. Add Sphinx index entries to make them more discoverable.
-
Fraser Tweedale authored
* cabal-install: extract url scheme checks Extract a bunch of string equality checks for the URI scheme to top-level functions. * cabal-install: refactor and document transport checks "They're the same picture". Thus, refactor the *transport supports https* checks. * cabal-install: allow Basic authentication in curl transport Allow the curl transport to use Basic authentication, if and only if the url scheme is HTTPS (i.e. TLS will be used). Retain the existing behaviour (force Digest scheme) for insecure requests. This change is required to support upcoming hackage-server changes. The wget transport already supports Basic authentication. --------- Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Brian J. Cardiff authored
* Add session to keep last chosen language * Drop do block in initCmd * Rename _runPrompt to runPrompt * Rename _runPromptState to runPromptState * Add type alias for NonEmpty String as Inputs * Split fmap and rename newSessionState * Rename arguments based on input and session (state) * Update UnitTest regarding _runPrompt rename * Make PromptIO a newtype * Formatting * Drop unneeded extensions * Hide MonadReader to consumes of PromptIO --------- Co-authored-by:
brandon s allbery kf8nh <allbery.b@gmail.com>
-
- Aug 20, 2024
-
-
mergify[bot] authored
Add git:// protocol check
-
f-a authored
-
f-a authored
-
f-a authored
-