Skip to content
Snippets Groups Projects

Revert "[Cmm Sized] Adjust"

Merged John Ericson requested to merge wip/sized-array-elem-types-in-primops into master

In old GHC:

I8# :: Int# -> Int8
indexInt8OffAddr# :: Addr# -> Int# -> Int#
...

In upcoming GHC 9.2:

I8# :: Int8# -> Int8
indexInt8OffAddr# :: Addr# -> Int# -> Int8#
...

Both of those work with the last array release, where the only requirement is merely that the constructor and primops agree, i.e.:

exists alpha.
I8# :: alpha -> Int8
indexInt8OffAddr# :: Addr# -> Int# -> alpha

In current GHC HEAD, we had

I8# :: Int8# -> Int8
indexInt8OffAddr# :: Addr# -> Int# -> Int#

and it was only because Int8# /= Int# that we needed the commit being reverted. we are about to fix the primops to match the constructors in accordance with the final 9.2 design, and so we don't need that commit anymore.

This reverts commit c7a696e3.

Merge request reports

Merged by Ben GamariBen Gamari 4 years ago (Mar 2, 2021 1:25am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading