Serge S. Gulin authored 3 months ago and Rufflewind committed 3 months ago

Co-authored-by: Cheng Shao <terrorjack@type.dance>

https://github.com/haskell/cabal/issues/10718 breaks the tests.

This is necessary to allow directory to be build with GHC

Fixes #192

Fixes #180

This header file is not supposed to be installed for users, users are
not supposed to use it. The file exists to be used interally (and this
is explained by the "include-dirs" field in the cabal file.

It seems likely that this removal was overlooked in
c87be990

removeDirectoryRecursive and removePathForcibly are supposed to never
traverse symbolic links, which would avoid unintended deletion of files
outside the specified directory tree.

The previous implementation did not "lock onto" the directory while
enumerating its entries, allowing concurrent processes to replace the
directory with a symlink right before or during the enumeration and
tricking the deleter into traversing the symlink (#97).

This commit mitigates the issue on POSIX systems by acquiring file
descriptors to every directory it traverses.

GHCs older than 8.6 (`base` less than 4.12) are not supported anymore.

When GetFinalPathNameByHandleW is unavailable, canonicalizePath falls
back to GetShortPathNameW + GetLongPathNameW, but that not always
guaranted to work. The documentation notes, for example:

> Resilient File System (ReFS) doesn't support short names. If you call
> GetShortPathName on a path that doesn't have any short names on-disk,
> the call will succeed, but will return the long-name path instead.

https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getshortpathnamew

Both windows-2019 and windows-2022 images on GitHub Actions no longer
seem to support GetShortPathNameW and so the tests have now begun to
fail.

Julian Ospald authored 11 months ago and Rufflewind committed 11 months ago

Fixes https://github.com/haskell/directory/issues/177

This has been failing since 2024-05-03:
https://github.com/haskell/directory/actions/runs/9152501865/job/25160038949

    Error: [S-9443]
           No setup information found for ghc-8.4.4 on your platform. This probably means a GHC binary
           distribution has not yet been added for OS key macosx-aarch64. Supported versions:
           ghc-8.10.5, ghc-8.10.6, ghc-8.10.7, ghc-9.0.2, ghc-9.2.1, ghc-9.2.2, ghc-9.2.3, ghc-9.2.4,
           ...

https://github.com/haskell-actions/setup/issues/77

Zubin authored 1 year ago and Rufflewind committed 1 year ago

Unix 2.8.5.0 is broken with os-string: true

As suggested here:
https://github.com/haskell/directory/commit/fc38cbfc5c7c4b631ed89d6b41bbe00ee96c8b21#r137623249

Fixes #170.

These cause deprecation warnings:
https://github.com/haskell/core-libraries-committee/issues/87

The Win32 version bound update has already been applied to 1.3.8.2 on
Hackage, so we will defer bumping the version to 1.3.8.3 until needed,
i.e. until a more significant change arrives.

Fixes #166.