Skip to content
Snippets Groups Projects
  • Matthew Pickering's avatar
    cb57c371
    external commands: Wait for process to finish before exiting (#10100) · cb57c371
    Matthew Pickering authored
    Issue #10063 points out that cabal exits before the external command
    has finished executing. This was a simple oversight to not
    waitForProcess on the result of calling createProcess.
    
    This also points out the flaw that there isn't a way for external
    commands to signal failure, so we now also propagate the exit code from
    the external process.
    
    Fixes #10063
    cb57c371
    History
    external commands: Wait for process to finish before exiting (#10100)
    Matthew Pickering authored
    Issue #10063 points out that cabal exits before the external command
    has finished executing. This was a simple oversight to not
    waitForProcess on the result of calling createProcess.
    
    This also points out the flaw that there isn't a way for external
    commands to signal failure, so we now also propagate the exit code from
    the external process.
    
    Fixes #10063
Code owners
Assign users and groups as approvers for specific file changes. Learn more.