* ci(mergify): upgrade configuration to current format

* patch up auto-upgrade brokenness

yet again

---------

Co-authored-by: Mergify <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: brandon s allbery kf8nh <allbery.b@gmail.com>

test suite: mark DedupUsingConfigFromSimple as flaky

see https://github.com/haskell/cabal/issues/10975

Fix PATH changes not triggering REPL reconfiguration (#2015)

Matthew Pickering authored 3 months ago and Mikolaj Konarski committed 2 weeks ago

When a user's PATH environment variable changes between Cabal commands,
the environment in the REPL becomes incorrect. This occurs because
during initial package configuration, the current PATH is captured via
`programSearchPathAsPATHVar` and then stored in the `programOverrideEnv`
field of a ConfiguredProgram. These `ConfiguredProgram`s are subsequently
serialized into the setup-config file, effectively baking in the PATH
environment from the time of configuration.

The issue manifests when `PATH` is updated after initial configuration.
Although the solver re-runs when detecting `PATH` changes, the
`dryRunLocalPkg` function examines `ElaboratedConfiguredPackage` and
incorrectly determines that nothing has changed that would require
reconfiguration. This decision is incorrect because `setup-config` now
contains a stale reference to the original `PATH` value, which no longer
matches the current environment.

To fix this problem, we need to store the `ConfiguredProgram`s directly in
`ElaboratedConfiguredPackage`. This approach will ensure that when `PATH`
changes, the `ConfiguredProgram`s will also change, properly triggering
reconfiguration. While this solution will cause more recompilations when
`PATH` changes, it guarantees that the correct environment is always used
during builds and REPL sessions.

An alternative approach would be to stop baking the `PATH` variable into
the environment of programs, but this would require more substantial
changes to how Cabal manages environment variables.

Fixes #2015

Adding JavaScript Preprocessor Support

Add JSPOptions tests

Add regressions tests

Co-authored-by: Mateusz Goslinowski <mateusz.goslinowski@gmail.com>

If ghc-options is not passed when compiling js, Cmm or asm, that's a bug

add GhcOptions test

partial fix for #10721

cabal-install.cabal: allow open-browser-0.4

Make `Flag a` a type synonym for `Last (Maybe a)`

Bodigrim authored 1 month ago and Mikolaj Konarski committed 4 weeks ago

As http://www.haskell.org/pipermail/cabal-devel/2007-December/001509.html
explains, `Data.Monoid.Last` was introduced only in base-3.0 and was too
new in 2007 to rely on. Thus a compatibility shim `data Flag a` was
vendored in.

We are long past 2007 and `Data.Monoid.Last` can now be used instead.
The commit keeps providing `Flag` and `NoFlag` as pattern synonyms
for backward compatibility, but makes `type Flag = Last.`

* ci(mergify): upgrade configuration to current format

* fixup! ci(mergify): upgrade configuration to current format

---------

Co-authored-by: Mergify <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: brandon s allbery kf8nh <allbery.b@gmail.com>

Mark untrimmed import test as flaky

Add Haddock documentation to Cabal's autogen modules

Implement assert matches with assert on

* Clarify splitting/passing behaviour for --*-option(s) arguments

* Further clarify precise quote parsing behaviour of --*-options options

* Use OPTS, not FLAG, for --repl-options

* Fix typo

* Fix formatting

* Use clearer notation for single and double quotes in docs

This handles geekosaur's review.

* Minor wording change in docs

Co-authored-by: brandon s allbery kf8nh <allbery.b@gmail.com>

---------

Co-authored-by: brandon s allbery kf8nh <allbery.b@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

- Add NeedleHaystackCompare
- Add tests of assertions
- Quote regex pattern
- Add regex tests
- Add assertOutputMatches tests
- Add tests using POSIX character classes
- Rename to TxFwdBwd
- Add isInfixOf predicate to assertOn calls

* print out the "Created semaphore" message only in verbose mode (#10885)

* fixup! Update pr-10936.md

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

bootstrap/bootstrap.py: Added support for multithreaded builds

Mark dedup complex test as flaky

- Sometimes fails with HTTP code 525, SSL handshake failure

always run changelog.d

We've made this a required job to ensure that changelogs are
always valid. But this means we can't use "paths", or PRs that
don't have changelogs will stall because the changelogs job
doesn't get run so it's never considered "succeeded".

This job is cheap, so run it unconditionally. We already know
things are currently valid, so this shouldn't produce any
surprises.

Removes a smattering of, apparent, dead code

Using weeder to find unused definitions. There are a great many more,
but this was an attempt to be relatively conservative in the removal.

Fix #9694 Don't imply that Haddock docs exist, when warning not installed

* Remove knowledge about haskell-suite and hmake

These tools haven't existed for at least a decade.

* Update hashes in testsuite

* Changelog for PR #10912

* Keep knowledge about retired error codes in comment

testsuite: Supress stderr when running integration tests

Matthew Pickering authored 2 months ago and Mikolaj Konarski committed 1 month ago

This fixes a problem where test output was leaking into GitHub Actions
results (#8419), making the output unnecessarily verbose and harder to read.

This makes the test output much cleaner while still preserving all the
diagnostic information when tests fail.

Also force the test to run sequentially, they fail if you try to run
them concurrently. I think that there are probably issues to do with
setting the working directory when using cabal-install as a library.

Fixes #8419

Allow building foreign libraries on FreeBSD

Fix call convention warnings for AArch64

Add module name validation in cabal check command