Skip to content
Snippets Groups Projects
Select Git revision
0 results
Search by author
  • Any Author
0 authors
This project is mirrored from https://github.com/haskell/Cabal.git. Pull mirroring updated .
  1. Jul 24, 2023
  3. Jul 20, 2023
    • Suganya Raju's avatar
      Cabal Error Refactor (#9018) · 667be468
      Suganya Raju authored 
      
* I have added a function "dieWithException" which will replace the die' calls and throws Error types as exception.
CabalException will hold all ErrorTypes, types will be incrementally added per module.
The VerboseException a will have CabalException and cabalInstallException variously in the a position

Utils.hs
1. Creation of Error data types
2. Diewithexception and exceptionCode function
3. Instance for VerboseException

Bench.hs and install.hs
1. Replaced die' call sites with dieWithException

Right now I have only added errors from two modules Distribtuion/Simple/Bench and Distribution/Simple/Install. Error types will be added incrementally.

* Codebase is formatted with fourmolu and compiled without warnings.

* Enabled fourmolu action

* Running fourmolu through github action as the previous ones failed.

* Function `exceptionWithMetadata` and constructors for each exception type

* I have added a function "dieWithException" which will replace the die' calls and throws Error types as exception.
CabalException will hold all ErrorTypes, types will be incrementally added per module.
The VerboseException a will have CabalException and cabalInstallException variously in the a position

Utils.hs
1. Creation of Error data types
2. Diewithexception and exceptionCode function
3. Instance for VerboseException

Bench.hs and install.hs
1. Replaced die' call sites with dieWithException

Right now I have only added errors from two modules Distribtuion/Simple/Bench and Distribution/Simple/Install. Error types will be added incrementally.

* Codebase is formatted with fourmolu and compiled without warnings.

* Enabled fourmolu action

* Running fourmolu through github action as the previous ones failed.

* Function `exceptionWithMetadata` and constructors for each exception type

* Updated changelog

* PatternMatching cases of diewithexception and displayexception reduced

* Delete fourmolu.yaml

This file is redundant.

* Delete settings.json

This file is redundant.

* Replaced die' calls for modules srcDist.hs and HcPkg.hs

* Replaced die' calls in modules `build.hs`,`Haddock.hs` and `Program.hs`

* Replaced die' calls in modules `Build.hs`, `Haddock.hs` and `Program.hs`

* Replaced die' calls in modules `GHCJS.hs`, `HaskellSuite.hs` and `BuildPaths.hs`

* Formatted the codebase with Fourmolu

* Accepted the new output with error codes and adding the file relevant to the test

* Changes in `Utils.hs` and `Errors.hs` to reflect the new error codes

* Keeping rip intact

* test changes

* CallStack unmarked from the error output

* callstack unmarked from output

* unmarked callstack in test output

* Format the codebase with fourmolu

* Changed to Error identifier to "Cabal-"

* Updated Constructors as per review comments

* Rectifying Hlint warning

---------

Co-authored-by: default avatarGershom Bazerman <gershom@arista.com>
      667be468
  5. Jul 18, 2023
    • mergify[bot]'s avatar
      Merge pull request #9139 from bgamari/wip/jsem · baa767a9
      mergify[bot] authored 
      Add support for using GHC's -jsem option
      baa767a9
    • Matthew Pickering's avatar
      Add support for using GHC's -jsem option · 0a1c167a
      Matthew Pickering authored and Ben Gamari's avatar Ben Gamari committed 
      * The top-level user interface to enable the use of the semaphore is the
  `--semaphore` flag. If you pass `-j4 --semaphore` then cabal will
  create a semaphore with 4 slots which is passed to ghc using the
  `-jsem` option so that all GHC processes coordinate to use 4
  capabilities.

  - The semaphore logic is provided by a new package `semaphore-compat`
    which provides a cross-platform abstraction for semaphores.

* The low level `./Setup.hs build` interface accepts the `--semaphore
  <SEMAPHORE>` option, which can be used to directly pass the semaphore
  you require to the Setup script.
      0a1c167a
    • Hécate Moonlight's avatar
      Fix tests · 249374d1
      Hécate Moonlight authored and Artem Pelenitsyn's avatar Artem Pelenitsyn committed
      249374d1
    • Ben Gamari's avatar
      cabal-install: Fix non-reinstallable package set · 2e32a44f
      Ben Gamari authored and Artem Pelenitsyn's avatar Artem Pelenitsyn committed 
      In #9064 we discovered that `ghc-boot` was added to the
non-reinstallable package set due to #8051 despite there being no
reason why it can't be built from its source distribution. This
revealed the fact that there is quite some ambiguity around what
constitutes a non-reinstallable package.

In #9064 we worked out a hopefully-more-clear picture of
non-reinstallability. Here we update the commentary to describe this
concept and update the lists to reflect the new definition.

Closes #9064.
      2e32a44f
    • Artem Pelenitsyn's avatar
      Mergify: add no-rebase rule · 6af0c085
      Artem Pelenitsyn authored 
      If a pull request gets the "merge+no rebase" label, it' will be merged directly to master without a rebase/squash or queue. This can be useful in cases when contributors don't allow updating their branches.
      6af0c085
    • Phil de Joux's avatar
      Follow hlint suggestion: redundant where · 20c480a6
      Phil de Joux authored and Artem Pelenitsyn's avatar Artem Pelenitsyn committed
      20c480a6
  7. Jul 16, 2023
  9. Jul 14, 2023
  11. Jul 13, 2023
  13. Jul 12, 2023
  15. Jul 11, 2023
  17. Jul 10, 2023
    • Phil de Joux's avatar
      Create default hlint configuration (with tidy up) · 31ae312d
      Phil de Joux authored and Artem Pelenitsyn's avatar Artem Pelenitsyn committed 
      * hlint --default -j . > .hlint.yaml

* Ignore modules that #include "MachDeps.h"

  Warning: Can't find file "MachDeps.h" in directories
	./cabal-testsuite/PackageTests/CmmSources/src
	.
  Asked for by: ./cabal-testsuite/PackageTests/CmmSources/src/Demo.hs  at line 8 col 1

  Warning: Can't find file "MachDeps.h" in directories
	./cabal-testsuite/PackageTests/CmmSourcesDyn/src
	.
  Asked for by: ./cabal-testsuite/PackageTests/CmmSourcesDyn/src/Demo.hs  at line 8 col 1

* Ignore the manually generated Lexer.hs

	templates/Lexer.x:10:1-20: Warning: Use fewer LANGUAGE pragmas
	Found:
	  {-# LANGUAGE CPP #-}
	  {-# LANGUAGE CPP #-}

	Perhaps:
	  {-# LANGUAGE CPP #-}

	1 hint

* Ignore templates/Paths_pkg.template.hs for its parse error

* Ignore templates/SPDX*.hs for their parse errors

* Add a linting workflow and rename the formatting one

* Redo default configuration with hlint-3.5

	I had mistakenly used a development build before:

	$ hlint --version
	HLint v3.6.20230213, (C) Neil Mitchell 2006-2022

* Shorten github workflow
      31ae312d
  19. Jul 09, 2023
  21. Jul 08, 2023
  23. Jul 06, 2023
  25. Jul 05, 2023