Skip to content
Snippets Groups Projects

Disable StrictMode

Open eliadh requested to merge eliadh/ghcup-hs:eliadh-master-patch-13530 into master

If StrictMode is set in a parent session (i.e., at the active powershell profile) the boot strap script will fail on uninitialized variables in case not all options are set to be installed: (i.e., $StackInstallExport in the Invoke-Command block at line 606)

https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/set-strictmode?view=powershell-5.1#description

Edited by eliadh

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • eliadh changed the description

    changed the description

  • Can you explain why the diff is so huge? I don't feel like I can review it this way.

  • Hi @maerwald , because there are white space changes, probably because i used the web editor for it. please try clear the box for "white space changes" in the web UI and see for yourself. if it still a problem i'll do it offline and re-submit.

    Thanks!

  • The way the script is usually invoked doesn't cause a child shell to be opened, so you'll effectively changing the strict mode of the users powershell session!

    See #408

    I want to improve that... we should spawn a real child shell, but I haven't gotten around doing that.

  • Yeh i see,

    it was probably because i usually work in windows through the terminal (instead of the usual double-click). so the parent is my terminal ..

    Thanks anyway

Please register or sign in to reply
Loading