Fixed mktempdir Darwin detection

The mktempdir function was testing whether mydistro = "darwin", but mydistro was not set.

mentioned in merge request !124 (merged)

Sorry for being a little impolite over in !124 (merged) ! No hard feelings :)

Just to be sure, my fix was to define mydistro using get_distro_name and get_distro_alias, and then unset it at the end of the function; this seemed to be what was done in other functions in the script.

Is this the correct way to fix the problem?

@hvr can you merge this with a signed commit? I'm currently not at home. This seems critical.

@Olius absolutely. The problem is that we can't really do 'set -u', because that is stupid behaviour for non-trivial shell scripts. The way forward is to have ghcup run on all major platforms during CI.

added 1 commit

• f4b8a209 - Changed "local" mydistro to mktemp_mydistro to avoid global name conflicts

Compare with previous version

resolved all threads

approved this merge request

merged

mentioned in issue #130 (closed)