Convert `Trace.Hpc.Markup.Summary` to use `lucid2` Georgy/lucid summary
Part of #18
Edited by Georgy Lukyanov
Merge request reports
Activity
mentioned in merge request !40 (closed)
154 <> "<th colspan=2>covered / total</th>" 155 <> "</tr>" 156 <> concat 157 [ showModuleSummary (modName, fileName, modSummary) 158 | (modName, fileName, modSummary) <- mods 159 ] 160 <> "<tr></tr>" 161 <> showTotalSummary 162 ( mconcat 163 [ modSummary 164 | (_, _, modSummary) <- mods 165 ] 166 ) 167 <> "</table></body>" 141 L.body_ $ 142 L.table_ [L.class_ "dashboard", L.width_ "100", border_ "1"] $ do changed this line in version 7 of the diff
84 85 last :: L.Html () 86 last = L.td_ [L.width_ "100"] (case percent ticked total of Nothing -> " "; Just w -> bar w "bar") 87 88 bar :: Int -> String -> L.Html () 82 89 bar 0 _ = bar 100 "invbar" 83 bar w inner = 84 "<table cellpadding=0 cellspacing=0 width=\"100\" class=\"bar\">" 85 <> "<tr><td><table cellpadding=0 cellspacing=0 width=\"" 86 <> show w 87 <> "%\">" 88 <> "<tr><td height=12 class=" 89 <> show inner 90 <> "></td></tr>" 91 <> "</table></td></tr></table>" 90 bar w inner = L.table_ [cellpadding_ "0", cellspacing_ "0", L.width_ "100", L.class_ "bar"] (L.tr_ (L.td_ innerTable)) changed this line in version 7 of the diff
87 88 bar :: Int -> String -> L.Html () 82 89 bar 0 _ = bar 100 "invbar" 83 bar w inner = 84 "<table cellpadding=0 cellspacing=0 width=\"100\" class=\"bar\">" 85 <> "<tr><td><table cellpadding=0 cellspacing=0 width=\"" 86 <> show w 87 <> "%\">" 88 <> "<tr><td height=12 class=" 89 <> show inner 90 <> "></td></tr>" 91 <> "</table></td></tr></table>" 90 bar w inner = L.table_ [cellpadding_ "0", cellspacing_ "0", L.width_ "100", L.class_ "bar"] (L.tr_ (L.td_ innerTable)) 91 where 92 innerTable :: L.Html () 93 innerTable = L.table_ [cellpadding_ "0", cellspacing_ "0", L.width_ (T.pack (show w))] tableContent changed this line in version 7 of the diff
I used https://onlinetextcompare.com/html and applied it to the before and after in the golden file to find the differences :)
Visual comparison of the output, before on the top, and after on the bottom (no visible difference):
Edited by Georgy Lukyanovadded 1 commit
- 10a24751 - Add non-braking space between the `module` keyword and name
added 19 commits
-
cc46d299 - 1 commit from branch
hpc:master
- cc46d299...26aa06b1 - 8 earlier commits
- 7e879c89 - Format body
- 7ccb1847 - Put `.html` into the name
- 0ac3880e - Convert one table row
- 42ae189f - Convert summary body to lucid2
- b88c01f8 - Fix warnings
- a5e793e6 - Apply ormolu
- a18c3ebe - Remove TypeApplications
- 0d1ea3c6 - Add percent sign to width attributes
- 822f45c0 - Actually, table cell needs width in pixels!
- a00b3a70 - Add non-braking space between the `module` keyword and name
Toggle commit list-
cc46d299 - 1 commit from branch
Please register or sign in to reply