- Nov 18, 2021
-
-
Javier Neira authored
* Use hackage version of czipwith * Update stack.yaml's * Remove source czipwith * Update index and clean cabal-ghc921.project * extra-1.7.9 has a breaking change so no way * Increase resources for circleci As for November 16, circleci has set a timeout of 1 hour for jobs in free plans Trying to increase resources to make the build faster as suggested by its support center * Use more threads reduce build times * Correct runs-on field * Update stack.yaml's * Dont fail fast if we are checking * Use ref_name to check it is a check * Bump patch version of brittany plugin * Allow newer base/th for czipwith * Add enough allow-newers to allow build the project Having all subpackages included in the `packages` field * Correct allow-newer's * Add missing cd's * Bump up ghcide to 1.5.0 * Exclude pkgs not buildable with 9.0.1 * Bum up plugins with changes versions * Bum up subpackages with changes versions * Bum up hls version to 1.5.0 * Bump up haddock plugin version * Allow ghcide 1.5 * Use ghcide 1.5.0 in the rest of plugins * Use ghcide 1.5.0 for pragmas * Allow tactics 1.5.0 for hls * Remove czipwith in hackage ci script * Disable 9.0.1 for hackage ci * Use bounds operator consistently * Build formatters with newer ghc-lib-parser * Only stylish-haskell needs newer ghc-lib * Avoid ghc-9.0.1 in other way * Script needs a min time version * First draft of 1.5.0 changelog * Comment out hackage for 9.0.1 * allow newer ghc-lib-parser * Remove redundant entry * Correct condition * Cancel previous hackage jobs * Add link to pepe's talk slides * Use th-extras master * Use th-extras master and uncomment packages * add extra-1.7.9 * Add required extra-deps * Comment unbuildable packages again * Add ignore-plugins-ghc-bounds * Add #2354 * Complete ghc deprecation notice * Add extra-1.7.9 * Add #2346 to Changelog
-
- Nov 17, 2021
-
-
Javier Neira authored
* Use hackage version of czipwith * Update stack.yaml's * Remove source czipwith * Update index and clean cabal-ghc921.project * extra-1.7.9 has a breaking change so no way * Increase resources for circleci As for November 16, circleci has set a timeout of 1 hour for jobs in free plans Trying to increase resources to make the build faster as suggested by its support center * Use more threads reduce build times * Correct runs-on field Co-authored-by:
Pepe Iborra <pepeiborra@gmail.com>
-
- Nov 16, 2021
-
-
Pepe Iborra authored
* Clean up previous entries in the exports map when updating it * Add typeText for local completions of type/class declarations helps with #2270 * add typeText for all local completions * fix test Co-authored-by:
Javier Neira <atreyu.bbb@gmail.com>
-
dependabot[bot] authored
Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 14.1 to 15. - [Release notes](https://github.com/cachix/install-nix-action/releases) - [Commits](https://github.com/cachix/install-nix-action/compare/v14.1...v15 ) --- updated-dependencies: - dependency-name: cachix/install-nix-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by:
Javier Neira <atreyu.bbb@gmail.com>
-
- Nov 15, 2021
-
-
Kota Yoshitsugu authored
* Skip parsing without haddock for above GHC9.0 * Use runtime ghc version check * Need parse twice in getParsedModuleRule * Include sortText in completions and improve suggestions (#2332) * sort completions * add an example * Include fuzzy scores in completions sort text * hlints * Extend completion documentation to inform whether an identifier is alreaady imported * Ditch alphabetical ordering - it's incompatible with qualified completions * Fix bugs in completion help text This fixes the ugly "Imported from 'Just B'" and other inconsistencies * added tests for qualified completions * Fix redundant import * Inline Fuzzy.match to apply [1] and to be case-sensitive on first match [1] - https://github.com/joom/fuzzy/pull/4 * fixup! Fix bugs in completion help text * Sort qualified completions first * Filter out global suggestions that overlap with local For example, don't suggest GHC.Exts.fromList when Data.Map.fromList is in scope alraedy * Sort completions alphabetically * Show provenance in detail text * Sort local/in-scope completions first * Fix build with GHC 9 * Ignore func symbol tests Co-authored-by:
Alex Naspo <alex.naspo@protonmail.com> Co-authored-by:
Javier Neira <atreyu.bbb@gmail.com> * Give unique names to post-jobs (#2337) * Restore comment * Parse only with Haddock above GHC90 * Remove obsolete comment Co-authored-by:
Pepe Iborra <pepeiborra@gmail.com> Co-authored-by:
Alex Naspo <alex.naspo@protonmail.com> Co-authored-by:
Javier Neira <atreyu.bbb@gmail.com>
-
- Nov 14, 2021
-
-
fendor authored
* Update to latest prettyprinter API * Update stack files to use prettyprinter 1.7.1
-
- Nov 12, 2021
-
-
Pepe Iborra authored
* Improve the performance of GetModIfaceFromDisk in large repos There are three benefits: 1. GetModIfaceFromDisk and GhcSessionDeps no longer depend on the transitive module summaries. This means fewer edges in the build graph = smaller build graph = faster builds 2. Avoid duplicate computations in setting up the GHC session with the dependencies of the module. Previously the total work done was O(NlogN) in the number of transitive dependencies, now it is O(N). 3. Increased sharing of HPT and FinderCache. Ideally we should also share the module graphs, but the datatype is abstract, doesn't have a monoid instance, and cannot be coerced to something that has. We will need to add the Monoid instance in GHC first. On the Sigma repo: - the startup metric goes down by ~34%. - The edit metric also goes down by 15%. - Max residency is down by 30% in the edit benchmark. * format importes * clean up * remove stale comment * fix build in GHC 9 * clean up * Unify defintions of ghcSessionDeps * mark test as no longer failing * Prevent duplicate missing module diagnostics * delete GetDependencies * add a test for deeply nested import cycles * Fix build in GHC 9.0 * bump ghcide version * Introduce config options for the main rules Surfacing the performance tradeoffs in the core build rules * Avoid using the Monoid instance (removed in 9.4 ?????) * Fix build with GHC 9 * Fix Eval plugin
-
- Nov 11, 2021
-
-
Pepe Iborra authored
* Show build graph statistics in ghcide-bench This adds 5 new columns to the benchmark outputs: - buildRulesBuilt - for which the value didn't change - buildRulesChanged - for which the value did change - buildRulesVisited - for which the value was not even recomputed - buildRulesTotal - including the rules that were not visited in the last build - buildEdges - total number of edges in the build graph * Fix build * backwards compat.
-
Anton Latukha authored
-
dependabot[bot] authored
-
dependabot[bot] authored
Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 13 to 14.1. - [Release notes](https://github.com/cachix/install-nix-action/releases) - [Commits](https://github.com/cachix/install-nix-action/compare/v13...v14.1 ) --- updated-dependencies: - dependency-name: cachix/install-nix-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by:
dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [fkirc/skip-duplicate-actions](https://github.com/fkirc/skip-duplicate-actions) from 3.4.0 to 3.4.1. - [Release notes](https://github.com/fkirc/skip-duplicate-actions/releases) - [Commits](https://github.com/fkirc/skip-duplicate-actions/compare/v3.4.0...v3.4.1 ) --- updated-dependencies: - dependency-name: fkirc/skip-duplicate-actions dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
- Nov 10, 2021
-
-
Anton Latukha authored
Dependabot would send merge requests [like these](haskell-nix/hnix-store#169) Co-authored-by:
Javier Neira <atreyu.bbb@gmail.com>
-
Pepe Iborra authored
* trace rule diagnostics * disable checkProject in HLS test suite We already disable this in ghcide tests It introduces noise (traces are harder to read), and can potentially break tests too (e.g. eval plugin) * Undo breaking auto-format * fix missing import * Fix splice plugin tests * Fix test Co-authored-by:
Javier Neira <atreyu.bbb@gmail.com>
-
Javier Neira authored
-
Pepe Iborra authored
* sort completions * add an example * Include fuzzy scores in completions sort text * hlints * Extend completion documentation to inform whether an identifier is alreaady imported * Ditch alphabetical ordering - it's incompatible with qualified completions * Fix bugs in completion help text This fixes the ugly "Imported from 'Just B'" and other inconsistencies * added tests for qualified completions * Fix redundant import * Inline Fuzzy.match to apply [1] and to be case-sensitive on first match [1] - https://github.com/joom/fuzzy/pull/4 * fixup! Fix bugs in completion help text * Sort qualified completions first * Filter out global suggestions that overlap with local For example, don't suggest GHC.Exts.fromList when Data.Map.fromList is in scope alraedy * Sort completions alphabetically * Show provenance in detail text * Sort local/in-scope completions first * Fix build with GHC 9 * Ignore func symbol tests Co-authored-by:
Alex Naspo <alex.naspo@protonmail.com> Co-authored-by:
Javier Neira <atreyu.bbb@gmail.com>
-
Javier Neira authored
* Rename test data files * Add regression tests * Add regression test for #1279 * Use timeout * Correct waitForProgressDone in ghcide * Remove unnecessary waitForDiagnostics * Mark test broken for hlint on ghclib * Add test over unused extensions * Add test for #2042 * Add data for #2280 * Use waitForAllProgressDone * Add test for #2280 * correct module name * Add reproduction for #2290 * Correct test case * Comment about knownBrokenForHlint* * Correction
-
- Nov 09, 2021
-
-
Javier Neira authored
* Cancel prev runs for bench and nix * Dont use skip-duplicate-actions for cancel others * Ignore format func-tests
-
- Nov 06, 2021
-
-
Kota Yoshitsugu authored
* Not suggest exported imports * Add testing explicit-imports-plugin to github workflow * Add comment Co-authored-by:
Michael Peyton Jones <me@michaelpj.com> Co-authored-by:
Michael Peyton Jones <me@michaelpj.com>
-
- Nov 03, 2021
-
-
Javier Neira authored
* [skip circleci] update troubleshooting * Removing the old issue about Path_ modules * Adding the issue about TH and multi component support with stack * Adding the strategy of disable plugins to help trace the cause * Rephrasing stack issue Co-authored-by:
Michael Peyton Jones <me@michaelpj.com> * Remove dead bullet Co-authored-by:
Michael Peyton Jones <me@michaelpj.com> * Repharsing/corrections Co-authored-by:
Michael Peyton Jones <me@michaelpj.com> * Rephrasing/corrections Co-authored-by:
Michael Peyton Jones <me@michaelpj.com> * Apply suggestions from code review Co-authored-by:
Michael Peyton Jones <me@michaelpj.com> Co-authored-by:
Michael Peyton Jones <me@michaelpj.com>
-
Kota Yoshitsugu authored
Co-authored-by:
Javier Neira <atreyu.bbb@gmail.com>
-
Javier Neira authored
* First temporal changes * Clean up tests plugin inclusion Deprecate them as they will be removed when all tests are moved to their own plugin packages * Use force-plugins in project files * Add ghc-9.0.1 to hackage release workflow Diabling actual upload if the branch contains 'check' * Improve force-plugins explanation * Correct deprecated pragma location * Dont use deprecated pragma * Correct yaml config error * Change flag name * Use new flag name in project files
-
- Nov 02, 2021
-
-
Javier Neira authored
* Ignore tests stucking ci * Enable func-test for win and 9.0.1
-
Julien Debon authored
Closes https://github.com/haskell/haskell-language-server/issues/2309 Co-authored-by:
Javier Neira <atreyu.bbb@gmail.com>
-
Javier Neira authored
It does not work for prs from external repos
-
- Oct 31, 2021
-
-
Pepe Iborra authored
-
Pepe Iborra authored
There's been a lot of work done on making hover and getDefinition immediately responsive at startup by using persisted data. Unfortunately we didn't install tests to preserve this fragile property. We should add those tests to the func-test testsuite. The problem here is that Tactics installs a hover handler that depends on the TypeCheck rule. Since there is no persistent provider for this rule, it blocks until the file can be typechecked. Since HLS does not implement partial responses (and neither do most LSP clients anyway), this blocks all the other hover providers. The solution is to install a new build rule GetMetaprograms that depends on TypeCheck, install a persistent provider for it that returns the empty list of meta programs, and switch the hover provider to useWithStaleFast. The downsides of doing this are negligible - the hover provider won't show any metaprogram specific info if used at startup, but it will work finely on a second attempt.
-
- Oct 30, 2021
-
-
Pepe Iborra authored
-
Javier Neira authored
* Add option to cancel prev runs Without using skip-duplicate-actions which is failing due to github access permission. See https://github.com/fkirc/skip-duplicate-actions/issues/103 * Cancel by branch *and* workflow Without it will cancel other workflows for the same branch Credits: 7b371e8b * Disable cancelling other runs Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
- Oct 29, 2021
-
-
Julien Debon authored
* Update documentation on using HIE with HLS Followup of https://github.com/haskell/haskell-language-server/pull/1230 * Cleanup some documentation links that are not visible with inline code
-
- Oct 28, 2021
-
-
Javier Neira authored
* Use new queue rules * Add queue action * Remove method from the queue rule * Correct yaml * Comment about empty conditions
-
Javier Neira authored
* Use post job to set workflow status * Apply post_job trick to bench and nix * Change label to skip circleci * Delete setup cache ide step * Skip circle ci when skipping gh * No skip circleci if its config change * Look for skip label in comments as well * Add missing condition * Use a explicit github token
-
- Oct 27, 2021
-
-
Michael Peyton Jones authored
[skip ci] Separate features from demos
-
Javier Neira authored
-
Javier Neira authored
-
Javier Neira authored
-
- Oct 26, 2021
-
-
Pepe Iborra authored
* attempt to fix hiedb lock errors it looks like the test runner has a preexisting process locking the hiedb * Move ghcide cache to the tmp folder * Use ${{ runner.temp }} * clean up the hie-bios cache too * The runner context doesn't exist outside the steps section
-
- Oct 25, 2021
-
-
Pepe Iborra authored
-
Pepe Iborra authored
* [hls-graph] clean up databaseDirtySet When I ported https://github.com/ndmitchell/shake/pull/802/files to hls-graph, I changed the encoding of the dirty set. Instead, Dirty became a constructor in the Status union. But the databaseDirtySet stayed around accidentally, leading to some confusion. * extract GetEvalComments rule * override NeedsCompilation rule in eval plugin to generate linkables when Evaluating In addition, we tune the newness check of the redefined NeedsCompilation rule so that the generated linkables are not thrown away unnecessarily, as described in: https://github.com/ndmitchell/shake/issues/794 * getLastBuildKeys * Test that the linkables are being produced * honor LSP_TEST_LOG_STDERR * add comments and use custom newness check in ghcide too * fix build * fix 9.0 build
-
- Oct 24, 2021
-
-
Pepe Iborra authored
When I ported reverse dependencies from Shake[1] I missed an important detail. While Shake models alwaysRerun as a dependency on an actual rule (AlwaysRerun), hls-graph models alwaysRerun by setting actionDeps to Nothing. This is important because dependencies are not computed for these rules, and therefore reverse dependency tracking doesn't do anything, which breaks correctness of dirty rebuilds This commit adds dependency tracking for alwaysRerun rules, and fixes reverse dependency tracking. The alternative would be following the Shake approach but I'm not sure what other implications this might have. [1] - https://github.com/ndmitchell/shake/pull/802
-