Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
GHC
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Jens Petersen
GHC
Commits
9c68db9d
Commit
9c68db9d
authored
13 years ago
by
Simon Marlow
Committed by
pcapriotti
12 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Read the source file timestamp *before* preprocessing (#6106)
MERGED from commit
d82da293
parent
cd00c771
Loading
Loading
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
compiler/main/GhcMake.hs
+11
-13
11 additions, 13 deletions
compiler/main/GhcMake.hs
with
11 additions
and
13 deletions
compiler/main/GhcMake.hs
+
11
−
13
View file @
9c68db9d
...
...
@@ -1213,16 +1213,14 @@ summariseFile hsc_env old_summaries file mb_phase obj_allowed maybe_buf
=
do
let
location
=
ms_location
old_summary
-- return the cached summary if the source didn't change
src_timestamp
<-
case
maybe_buf
of
Just
(
_
,
t
)
->
return
t
Nothing
->
liftIO
$
getModificationTime
file
src_timestamp
<-
get_src_timestamp
-- The file exists; we checked in getRootSummary above.
-- If it gets removed subsequently, then this
-- getModificationTime may fail, but that's the right
-- behaviour.
if
ms_hs_date
old_summary
==
src_timestamp
-- return the cached summary if the source didn't change
if
ms_hs_date
old_summary
==
src_timestamp
then
do
-- update the object-file timestamp
obj_timestamp
<-
if
isObjectTarget
(
hscTarget
(
hsc_dflags
hsc_env
))
...
...
@@ -1231,12 +1229,17 @@ summariseFile hsc_env old_summaries file mb_phase obj_allowed maybe_buf
else
return
Nothing
return
old_summary
{
ms_obj_date
=
obj_timestamp
}
else
new_summary
new_summary
src_timestamp
|
otherwise
=
new_summary
=
do
src_timestamp
<-
get_src_timestamp
new_summary
src_timestamp
where
new_summary
=
do
get_src_timestamp
=
case
maybe_buf
of
Just
(
_
,
t
)
->
return
t
Nothing
->
liftIO
$
getModificationTime
file
new_summary
src_timestamp
=
do
let
dflags
=
hsc_dflags
hsc_env
(
dflags'
,
hspp_fn
,
buf
)
...
...
@@ -1251,11 +1254,6 @@ summariseFile hsc_env old_summaries file mb_phase obj_allowed maybe_buf
-- to findModule will find it, even if it's not on any search path
mod
<-
liftIO
$
addHomeModuleToFinder
hsc_env
mod_name
location
src_timestamp
<-
case
maybe_buf
of
Just
(
_
,
t
)
->
return
t
Nothing
->
liftIO
$
getModificationTime
file
-- getMofificationTime may fail
-- when the user asks to load a source file by name, we only
-- use an object file if -fobject-code is on. See #1205.
obj_timestamp
<-
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment