Update Cabal submodule & ghc-pkg to use new module re-export types
Summary: The main change is that Cabal changed the representation of module re-exports to distinguish reexports in source .cabal files versus re-exports in installed package registraion files. Cabal now also does the resolution of re-exports to specific installed packages itself, so ghc-pkg no longer has to do this. This is a cleaner design overall because re-export resolution can fail so it is better to do it during package configuration rather than package registration. It also simplifies the re-export representation that ghc-pkg has to use. Add extra ghc-pkg sanity check for module re-exports and duplicates For re-exports, check that the defining package exists and that it exposes the defining module (or for self-rexport exposed or hidden modules). Also check that the defining package is actually a direct or indirect dependency of the package doing the re-exporting. Also add a check for duplicate modules in a package, including re-exported modules. Test Plan: So far the sanity checks are totally untested. Should add some test case to make sure the sanity checks do catch things correctly, and don't ban legal things. Reviewers: austin, duncan Subscribers: angerman, simonmar, ezyang, carter Differential Revision: https://phabricator.haskell.org/D183 GHC Trac Issues:
Showing
- compiler/main/Packages.lhs 5 additions, 1 deletioncompiler/main/Packages.lhs
- ghc.mk 2 additions, 2 deletionsghc.mk
- libraries/Cabal 1 addition, 1 deletionlibraries/Cabal
- testsuite/tests/cabal/ghcpkg07.stdout 6 additions, 8 deletionstestsuite/tests/cabal/ghcpkg07.stdout
- testsuite/tests/cabal/test7a.pkg 2 additions, 1 deletiontestsuite/tests/cabal/test7a.pkg
- testsuite/tests/cabal/test7b.pkg 3 additions, 2 deletionstestsuite/tests/cabal/test7b.pkg
- testsuite/tests/perf/haddock/all.T 2 additions, 1 deletiontestsuite/tests/perf/haddock/all.T
- utils/ghc-cabal/Main.hs 1 addition, 1 deletionutils/ghc-cabal/Main.hs
- utils/ghc-cabal/ghc.mk 1 addition, 0 deletionsutils/ghc-cabal/ghc.mk
- utils/ghc-pkg/Main.hs 76 additions, 203 deletionsutils/ghc-pkg/Main.hs
Loading
Please register or sign in to comment