Fix test suite wobbliness on GHC 8.2.
Here were the root causes:
- Some tests involving Custom setpu showed MORE output
(UseLocalPackageForSetup) when run on GHC 8.2. This is because GHC
8.2 ships a recent enough version of Cabal to know how to emit
markers, which means we have started picking up the output. I hacked
up these tests to not accept this output, but a more correct thing to
do is figure out how to NOT request marking of a Setup script which is
not the inplace install. This was a little tricky so I bailed.
- GHC 8.2 no longer emits "It is a member of the hidden package".
This broke CustomWithoutCabalDefaultMain. Not sure if this
is a GHC regression but it's pretty harmless.
- While I was at it, I fixed an inexhaustive pattern match in
cabal-testsuite (though perhaps poorly; I couldn't figure out
what the new constructor does.)
Signed-off-by:
Edward Z. Yang <ezyang@cs.stanford.edu>
Showing
- cabal-testsuite/PackageTests/Backpack/T4447/setup.cabal.out 10 additions, 0 deletionscabal-testsuite/PackageTests/Backpack/T4447/setup.cabal.out
- cabal-testsuite/PackageTests/BuildTargets/UseLocalPackageForSetup/use-local-package-as-setup-dep.out 0 additions, 13 deletions...seLocalPackageForSetup/use-local-package-as-setup-dep.out
- cabal-testsuite/PackageTests/BuildTargets/UseLocalPackageForSetup/use-local-package-as-setup-dep.test.hs 5 additions, 1 deletion...calPackageForSetup/use-local-package-as-setup-dep.test.hs
- cabal-testsuite/PackageTests/CustomWithoutCabalDefaultMain/cabal.test.hs 3 additions, 0 deletions.../PackageTests/CustomWithoutCabalDefaultMain/cabal.test.hs
- cabal-testsuite/PackageTests/NewBuild/CustomSetup/LocalPackageWithCustomSetup/build-local-package-with-custom-setup.out 0 additions, 9 deletions...WithCustomSetup/build-local-package-with-custom-setup.out
- cabal-testsuite/PackageTests/NewBuild/CustomSetup/LocalPackageWithCustomSetup/build-local-package-with-custom-setup.test.hs 1 addition, 1 deletion...CustomSetup/build-local-package-with-custom-setup.test.hs
- cabal-testsuite/PackageTests/NewBuild/CustomSetup/LocalPackageWithCustomSetup/pkg.cabal 1 addition, 0 deletions...ewBuild/CustomSetup/LocalPackageWithCustomSetup/pkg.cabal
- cabal-testsuite/PackageTests/NewBuild/T4450/cabal.out 0 additions, 11 deletionscabal-testsuite/PackageTests/NewBuild/T4450/cabal.out
- cabal-testsuite/PackageTests/NewBuild/T4450/cabal.test.hs 4 additions, 2 deletionscabal-testsuite/PackageTests/NewBuild/T4450/cabal.test.hs
- cabal-testsuite/Test/Cabal/Server.hs 2 additions, 1 deletioncabal-testsuite/Test/Cabal/Server.hs
Loading
Please register or sign in to comment