Zubin authored 2 years ago and Julian Ospald committed 2 years ago

more ubuntu fixes

more ubuntu fixes

Fixes #3169

Upgrade a few packages which needed upgrade and avoid building hiedb in
nix as it has a dependency on a package in this repository (hie-compat).

Co-authored-by: Michael Peyton Jones <me@michaelpj.com>

Following discussion in
https://github.com/haskell/haskell-language-server/discussions/3123.

This aims to make it more obvious what it means when we say we support a
version of GHC.

Bumps [fkirc/skip-duplicate-actions](https://github.com/fkirc/skip-duplicate-actions) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/fkirc/skip-duplicate-actions/releases)
- [Commits](https://github.com/fkirc/skip-duplicate-actions/compare/v5.1.0...v5.2.0

)

---
updated-dependencies:
- dependency-name: fkirc/skip-duplicate-actions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Cause i am getting lot of notifications i dont have time to attend

Co-authored-by: Michael Peyton Jones <me@michaelpj.com>

* add test case

* handle error more properly

* add an error type

* fix tests

* log the bad dependency case

This still makes sure that ghc has been compiled with the same core
libraries as hls while it allows runtime environments where other
packages have been added to the ghc-pkg database.

This commit also adds that file to the sdist, so that distro
packagers can use it.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

This commit replaces manually specified `myst-parser` and `sphinx_rtd_theme`
packages with their counterparts already packaged on nixpkgs. With this
change, `poetry2nix` is no more used, therefore that is removed as well.

* baseline for record completions

* address feedback

* gate ghc version

* add test

* refactor

* fix rope import

* fix plugins from rebase

* gate test by ghc version

* comments, fixes

* fix ghc90 test

Remove warning about hlint restrictions, as #1340 has been merged.

Co-authored-by: Michael Peyton Jones <me@michaelpj.com>

Bumps [fkirc/skip-duplicate-actions](https://github.com/fkirc/skip-duplicate-actions) from 4.0.0 to 5.1.0.
- [Release notes](https://github.com/fkirc/skip-duplicate-actions/releases)
- [Commits](https://github.com/fkirc/skip-duplicate-actions/compare/v4.0.0...v5.1.0

)

---
updated-dependencies:
- dependency-name: fkirc/skip-duplicate-actions
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* remove 'buildable: False' in cabal

* remove constraint on ghc-exactprint

* wip

* revert HaddockComments.hs

* generate haddock comments for constructors

* fix tests

* restore constraints

* make it compatible with ghc 9.0

* add more tests

* add comments & fix dp calculation for inline case

* add kokobd to codeowners of haddock-comments plugin

* fix a comment

* rephrase some comments to make them clearer

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Makes it easier to copy and paste configurations into VSCode and
reviewing what options have been added and removed.

Remove code-duplication, namely ghcide exe loses some capabilities, as
it is destined to be removed sooner or later.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Michael Peyton Jones <me@michaelpj.com>

Add a source-repository stanza to any .cabal files in the project that
are missing it.

This metadata can be useful for package maintainers.

See: https://cabal.readthedocs.io/en/stable/cabal-package.html#source-repositories



Signed-off-by: hololeap <hololeap@users.noreply.github.com>

Signed-off-by: hololeap <hololeap@users.noreply.github.com>

* Log plugin name

* redundant import

* Attribute response error logs to plugins

* remove redundant plugin names from error messages

* improve pretty printing

* Avoid show

* simplify test messages

* Fix

* Fix broken tests for signatures

* Remove unused Maybe

* Refactir prepare

* Refactor incoming and outgoing calls

* Fix doc format

Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>
Co-authored-by: Michael Peyton Jones <me@michaelpj.com>

* save some progress: add basic starter code for folding ranges

* save some progress: add function to traverse through coderange and form folding ranges

* save some progress: add parsing of folding ranges

* fix: maybe issue with foldingRanges

* add: generate folding ranges from coderange

* add: plugin request method instance for folding ranges

* ref: alter function and var names

* post review: cleanup crk to frk & fix typo

* fix: find folding ranges function

* format: run formatter and add comments

* fix: return all response results of folding range request

* Revert "format: run formatter and add comments"

This reverts commit e6a2b5ca3e8232bc082ce84d22545a5bd462a2ff.

* add: removed comments after revert

* fix: formatting

* docs: add folding range to features section and cabal file

* refactor: use destructuring for createFoldingRange function and use characters

* test: add basic unit test for findFoldingRanges function

* test: add tests for children and code kind

* test: add more test cases

* test: add test for createFoldingRange

* test: add integration test for folding ranges

* fix: duplicate start line foldingranges and remove single line
foldingranges

* refactor: duplicate folding range functionality

* fix: formatting in code range plugin

* added more descriptive comments and encorporate code review suggestions

* revert: automatic formatting for selection range test case file

* fix: ignoring children if root fails to provide folding ranges

* remove: redundant match on crkToFrk

* revert: filtering same line foldings and multiple foldings on the same line as it can be handled by clients

* revert: formatting change to selection range test file

* fix: entire file folding because of root node

Co-authored-by: Kobayashi <contact@zelinf.net>

* Stylish Haskell: Parse issues

* CPP language extension
* Manually fix some files with duplication

* Pre-commit: Fix ignored files

It looks like `ExactPrint` was ignored before, but since absolute paths
are used and weren't adapted it wasn't ignored afterwards.

Bumps [technote-space/get-diff-action](https://github.com/technote-space/get-diff-action) from 4.0.1 to 6.1.0.
- [Release notes](https://github.com/technote-space/get-diff-action/releases)
- [Changelog](https://github.com/technote-space/get-diff-action/blob/main/.releasegarc)
- [Commits](https://github.com/technote-space/get-diff-action/compare/v4.0.1...v6.1.0

)

---
updated-dependencies:
- dependency-name: technote-space/get-diff-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Only run the pre-commit hook on changed files

* Let's change a haskell file

* Didn't use the PATTERN field correctly

* Move pre-commit block before building stylish-haskell

* Try to evaluate GIT_DIFF value to pass to pre-commit

* Try to evaluate GIT_DIFF value to pass to pre-commit

* Move pre-commit action back to original spot

* Introduce bad formatting in a file

* Conditionally run the pre-commit job only when there are haskell source
changes

* Restore haskell files we used for testing

* workflow fixes

* Try changing haskell source files with new workflow structure

* Revert all changes to files during testing

Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>

`isPreferred` can influence the client side order of code actions. The
idea is that an unused import is likely to be removed and less likely
the warning will be disabled. Therefore actions to remove a single or
all redundant imports should be preferred, so that the client can
prioritize them higher.

Followup of
<https://github.com/haskell/haskell-language-server/pull/3018>

* Solve formatting issues

* stylish-haskell parse errors solved (partially)

* Env: Changing order (import)
* Plugins: Dangling `$`

Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>

Adding an example with settings

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>

Fixes #3172.

* Check on close modes were removed
* Moving docs to configuration and away from ghcide README

Respects globalOn in stan plugin configuration and won't show hints
anymore if the plugin is disabled.

Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>

nix: fix nix environment for GHC 9.4

- Bumped nixpkgs, so that's a true GHC 9.4.2 and not 9.4.0, which was
  failing in cabal which because it was detecting <=9.4.1.
- Fixed GHC 9.4 overrides for dependencies
- Use the "default" GHC environment for tooling in the shell. Hence it
  rebuilds less.
- I introduced a flake for cabal-hashes, hence it can be updated
  automatically (with `nix flake update`) and hence we can use
  `callHackage` for any hackage package.

* unescape printable characters

* add comments

* add tests

* improve the parser

* simplify code & add more docs